Fix lint issues

Author: LijieZhang1998

.changelog/3680.txt

@@ -1,3 +1,3 @@
 ```release-note:enhancement
-streamconnection/resource_stream_connection: Add new authentication mechanism(OIDC) to the Kafka connection
+resource/mongodbatlas_stream_connection: Add new authentication mechanism(OIDC) to the Kafka connection
 ```

internal/service/streamconnection/model_stream_connection_test.go

@@ -11,16 +11,17 @@ import (
 )
 
 const (
-	connectionName            = "Connection"
-	typeValue                 = ""
-	clusterName               = "Cluster0"
-	dummyProjectID            = "111111111111111111111111"
-	instanceName              = "InstanceName"
-	authMechanism             = "PLAIN"
-	authMechanismOAuth        = "OAUTHBEARER"
-	authUsername              = "user1"
-	clientID                  = "auth0Client"
-	clientSecret              = "secret"
+	connectionName     = "Connection"
+	typeValue          = ""
+	clusterName        = "Cluster0"
+	dummyProjectID     = "111111111111111111111111"
+	instanceName       = "InstanceName"
+	authMechanism      = "PLAIN"
+	authMechanismOAuth = "OAUTHBEARER"
+	authUsername       = "user1"
+	clientID           = "auth0Client"
+	clientSecret       = "secret"
+	// #nosec G101
 	tokenEndpointURL          = "https://your-domain.com/oauth2/token"
 	scope                     = "read:messages write:messages"
 	saslOauthbearerExtentions = "logicalCluster=cluster-kmo17m,identityPoolId=pool-l7Arl"
@@ -642,13 +643,13 @@ func tfAuthenticationObject(t *testing.T, mechanism, username, password string)
 	return auth
 }
 
-func tfAuthenticationObjectForOAuth(t *testing.T, mechanism, clientId, clientSecret, tokenEndpointUrl, scope, saslOauthbearerExtensions, httpsCaPem string) types.Object {
+func tfAuthenticationObjectForOAuth(t *testing.T, mechanism, clientID, clientSecret, tokenEndpointURL, scope, saslOauthbearerExtensions, httpsCaPem string) types.Object {
 	t.Helper()
 	auth, diags := types.ObjectValueFrom(t.Context(), streamconnection.ConnectionAuthenticationObjectType.AttrTypes, streamconnection.TFConnectionAuthenticationModel{
 		Mechanism:                 types.StringValue(mechanism),
-		ClientID:                  types.StringValue(clientId),
+		ClientID:                  types.StringValue(clientID),
 		ClientSecret:              types.StringValue(clientSecret),
-		TokenEndpointURL:          types.StringValue(tokenEndpointUrl),
+		TokenEndpointURL:          types.StringValue(tokenEndpointURL),
 		Scope:                     types.StringValue(scope),
 		SaslOauthbearerExtensions: types.StringValue(saslOauthbearerExtensions),
 		HTTPSCaPem:                types.StringValue(httpsCaPem),

internal/service/streamconnection/resource_stream_connection_test.go

@@ -404,7 +404,7 @@ func TestAccStreamRSStreamConnection_AWSLambda(t *testing.T) {
 	})
 }
 
-func getKafkaAuthenticationConfig(mechanism, username, password, tokenEndpointUrl, clientId, clientSecret, scope, saslOauthbearerExtensions, httpsCaPem string) string {
+func getKafkaAuthenticationConfig(mechanism, username, password, tokenEndpointURL, clientID, clientSecret, scope, saslOauthbearerExtensions, httpsCaPem string) string {
 	if mechanism == "PLAIN" {
 		return fmt.Sprintf(`authentication = {
 			mechanism = %[1]q
@@ -420,8 +420,7 @@ func getKafkaAuthenticationConfig(mechanism, username, password, tokenEndpointUr
 			scope = %[5]q
 			sasl_oauthbearer_extensions = %[6]q
 			https_ca_pem = %[7]q
-		}`, mechanism, tokenEndpointUrl, clientId, clientSecret, scope, saslOauthbearerExtensions, httpsCaPem)
-
+		}`, mechanism, tokenEndpointURL, clientID, clientSecret, scope, saslOauthbearerExtensions, httpsCaPem)
 }
 
 func configureKafka(projectID, instanceName, connectionName, authenticationConfig, bootstrapServers, configValue, networkingConfig string, useSSL bool) string {
@@ -524,16 +523,16 @@ func checkKafkaAttributes(
 }
 
 func checkKafkaOAuthAttributes(
-	resourceName, instanceName, connectionName, tokenEndpointUrl, clientId, clientSecret, scope, saslOauthbearerExtensions, httpsCaPem, bootstrapServers, configValue, networkingType string, usesSSL, checkClientSecret bool) resource.TestCheckFunc {
+	resourceName, instanceName, connectionName, tokenEndpointURL, clientID, clientSecret, scope, saslOauthbearerExtensions, httpsCaPem, bootstrapServers, configValue, networkingType string, usesSSL, checkClientSecret bool) resource.TestCheckFunc {
 	resourceChecks := []resource.TestCheckFunc{
 		checkStreamConnectionExists(),
 		resource.TestCheckResourceAttrSet(resourceName, "project_id"),
 		resource.TestCheckResourceAttr(resourceName, "connection_name", connectionName),
 		resource.TestCheckResourceAttr(resourceName, "type", "Kafka"),
 		resource.TestCheckResourceAttr(resourceName, "instance_name", instanceName),
 		resource.TestCheckResourceAttr(resourceName, "authentication.mechanism", "OAUTHBEARER"),
-		resource.TestCheckResourceAttr(resourceName, "authentication.token_endpoint_url", tokenEndpointUrl),
-		resource.TestCheckResourceAttr(resourceName, "authentication.client_id", clientId),
+		resource.TestCheckResourceAttr(resourceName, "authentication.token_endpoint_url", tokenEndpointURL),
+		resource.TestCheckResourceAttr(resourceName, "authentication.client_id", clientID),
 		resource.TestCheckResourceAttr(resourceName, "authentication.scope", scope),
 		resource.TestCheckResourceAttr(resourceName, "authentication.sasl_oauthbearer_extensions", saslOauthbearerExtensions),
 		resource.TestCheckResourceAttr(resourceName, "authentication.https_ca_pem", httpsCaPem),