Skip to content

Commit f7eb77b

Browse files
authored
feat: does not delete project for trigger acctest. (#1573)
* does not delete project for trigger acctest. * feat: enables acc test for event triggers. (#1574) * feat: sets up acc test for event triggers. * temp always enable tests. * adds realm base url as variable. * fixes api keys. * Revert "temp always enable tests." This reverts commit e376040.
1 parent 707de42 commit f7eb77b

File tree

5 files changed

+44
-12
lines changed

5 files changed

+44
-12
lines changed

.github/workflows/acceptance-tests.yml

Lines changed: 43 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ jobs:
3232
network: ${{ steps.filter.outputs.network }}
3333
config: ${{ steps.filter.outputs.config }}
3434
assume_role: ${{ steps.filter.outputs.assume_role }}
35+
event_trigger: ${{ steps.filter.outputs.event_trigger }}
3536
steps:
3637
- uses: actions/checkout@v4
3738
if: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' || inputs.parent-event-name == 'release' }}
@@ -81,7 +82,6 @@ jobs:
8182
- 'mongodbatlas/data_source_mongodbatlas_custom_db_role*.go'
8283
- 'mongodbatlas/data_source_mongodbatlas_custom_dns_configuration_cluster_aws*.go'
8384
- 'mongodbatlas/fw_data_source_mongodbatlas_database_user*.go'
84-
- 'mongodbatlas/data_source_mongodbatlas_event_trigger*.go'
8585
- 'mongodbatlas/data_source_mongodbatlas_maintenance_window*.go'
8686
- 'mongodbatlas/data_source_mongodbatlas_org_id*.go'
8787
- 'mongodbatlas/data_source_mongodbatlas_org_invitation*.go'
@@ -97,14 +97,17 @@ jobs:
9797
- 'mongodbatlas/resource_mongodbatlas_custom_db_role*.go'
9898
- 'mongodbatlas/resource_mongodbatlas_custom_dns_configuration_cluster_aws*.go'
9999
- 'mongodbatlas/fw_resource_mongodbatlas_database_user*.go'
100-
- 'mongodbatlas/resource_mongodbatlas_event_trigger*.go'
101100
- 'mongodbatlas/resource_mongodbatlas_maintenance_window*.go'
102101
- 'mongodbatlas/resource_mongodbatlas_org_invitation*.go'
103102
- 'mongodbatlas/resource_mongodbatlas_organization*.go'
104103
- 'mongodbatlas/resource_mongodbatlas_project_api_key*.go'
105104
- 'mongodbatlas/resource_mongodbatlas_search_index*.go'
106105
- 'mongodbatlas/resource_mongodbatlas_team*.go'
107-
- 'mongodbatlas/resource_mongodbatlas_third_party_integration*.go'
106+
- 'mongodbatlas/resource_mongodbatlas_third_party_integration*.go'
107+
event_trigger:
108+
- 'mongodbatlas/resource_mongodbatlas_event_trigger*.go'
109+
- 'mongodbatlas/data_source_mongodbatlas_event_trigger*.go'
110+
108111
109112
fetch-sts-assume-role-creds:
110113
runs-on: ubuntu-latest
@@ -478,4 +481,41 @@ jobs:
478481
PARALLEL_GO_TEST: 20
479482
CI: true
480483
TEST_REGEX: "^TestAccSTSAssumeRole"
484+
run: make testacc
485+
486+
event_trigger:
487+
needs: [ change-detection ]
488+
if: ${{ needs.change-detection.outputs.config == 'true' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' || github.event.label.name == 'run-testacc' || github.event.label.name == 'run-testacc-config' || inputs.parent-event-name == 'release' }}
489+
runs-on: ubuntu-latest
490+
steps:
491+
- name: Checkout
492+
uses: actions/checkout@v4
493+
- name: Set up Go
494+
uses: actions/setup-go@v4
495+
with:
496+
go-version-file: 'go.mod'
497+
- name: Acceptance Tests
498+
env:
499+
MONGODB_ATLAS_BASE_URL: ${{ vars.MONGODB_ATLAS_BASE_URL }}
500+
MONGODB_REALM_BASE_URL: ${{ vars.REALM_BASE_URL }}
501+
MONGODB_ATLAS_PUBLIC_KEY: ${{ secrets.MONGODB_ATLAS_PUBLIC_KEY_CLOUD_DEV }}
502+
MONGODB_ATLAS_PRIVATE_KEY: ${{ secrets.MONGODB_ATLAS_PRIVATE_KEY_CLOUD_DEV }}
503+
MONGODB_ATLAS_PROJECT_OWNER_ID: ${{ vars.MONGODB_ATLAS_PROJECT_OWNER_ID }}
504+
MONGODB_ATLAS_ORG_ID: ${{ vars.MONGODB_ATLAS_ORG_ID_CLOUD_DEV_NETWORK }}
505+
MONGODB_ATLAS_PROJECT_ID: ${{ vars.MONGODB_ATLAS_ACCTEST_TRIGGER_PROJECT_ID_CLOUD_DEV }}
506+
507+
AWS_EVENTBRIDGE_ACCOUNT_ID: ${{ secrets.AWS_EVENTBRIDGE_ACCOUNT_ID }}
508+
AWS_REGION: ${{ vars.AWS_REGION }}
509+
510+
MONGODB_REALM_APP_ID: ${{ vars.MONGODB_ATLAS_ACCTEST_TRIGGER_APP_ID_CLOUD_DEV }}
511+
MONGODB_REALM_FUNCTION_ID: ${{ vars.MONGODB_ATLAS_ACCTEST_TRIGGER_FUNCTION_ID_CLOUD_DEV }}
512+
MONGODB_REALM_SERVICE_ID: ${{ vars.MONGODB_ATLAS_ACCTEST_TRIGGER_SERVICE_ID_CLOUD_DEV }}
513+
514+
SKIP_TEST_EXTERNAL_CREDENTIALS: ${{ vars.SKIP_TEST_EXTERNAL_CREDENTIALS }}
515+
ACCTEST_TIMEOUT: ${{ vars.ACCTEST_TIMEOUT }}
516+
TF_LOG: ${{ vars.LOG_LEVEL }}
517+
TF_ACC: 1
518+
PARALLEL_GO_TEST: 20
519+
CI: true
520+
TEST_REGEX: "^TestAccConfigRSEventTrigger"
481521
run: make testacc

.github/workflows/cleanup-test-env.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ jobs:
2727
MONGODB_ATLAS_PRIVATE_API_KEY: ${{ secrets.MONGODB_ATLAS_PRIVATE_KEY_CLOUD_DEV }}
2828
MONGODB_ATLAS_ORG_ID: ${{ vars.MONGODB_ATLAS_ORG_ID_CLOUD_DEV }}
2929
MONGODB_ATLAS_OPS_MANAGER_URL: ${{vars.MONGODB_ATLAS_BASE_URL}}
30+
PROJECT_TO_NOT_DELETE: ${{vars.MONGODB_ATLAS_ACCTEST_TRIGGER_PROJECT_ID_CLOUD_DEV}}
3031
run: ./scripts/cleanup-test-env.sh
3132
clenup-test-env-network:
3233
runs-on: ubuntu-latest

mongodbatlas/data_source_mongodbatlas_event_trigger_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import (
1313
)
1414

1515
func TestAccConfigDSEventTrigger_basic(t *testing.T) {
16-
SkipTestForCI(t)
1716
var (
1817
resourceName = "mongodbatlas_event_trigger.test"
1918
projectID = os.Getenv("MONGODB_ATLAS_PROJECT_ID")

mongodbatlas/data_source_mongodbatlas_event_triggers_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import (
1212
)
1313

1414
func TestAccConfigDSEventTriggers_basic(t *testing.T) {
15-
SkipTestForCI(t)
1615
var (
1716
resourceName = "mongodbatlas_event_trigger.test"
1817
projectID = os.Getenv("MONGODB_ATLAS_PROJECT_ID")

mongodbatlas/resource_mongodbatlas_event_trigger_test.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import (
1616
)
1717

1818
func TestAccConfigRSEventTriggerDatabase_basic(t *testing.T) {
19-
SkipTestForCI(t)
2019
var (
2120
resourceName = "mongodbatlas_event_trigger.test"
2221
projectID = os.Getenv("MONGODB_ATLAS_PROJECT_ID")
@@ -79,7 +78,6 @@ func TestAccConfigRSEventTriggerDatabase_basic(t *testing.T) {
7978
}
8079

8180
func TestAccConfigRSEventTriggerDatabase_eventProccesor(t *testing.T) {
82-
SkipTestForCI(t)
8381
var (
8482
resourceName = "mongodbatlas_event_trigger.test"
8583
projectID = os.Getenv("MONGODB_ATLAS_PROJECT_ID")
@@ -145,7 +143,6 @@ func TestAccConfigRSEventTriggerDatabase_eventProccesor(t *testing.T) {
145143
}
146144

147145
func TestAccConfigRSEventTriggerAuth_basic(t *testing.T) {
148-
SkipTestForCI(t)
149146
var (
150147
resourceName = "mongodbatlas_event_trigger.test"
151148
projectID = os.Getenv("MONGODB_ATLAS_PROJECT_ID")
@@ -204,7 +201,6 @@ func TestAccConfigRSEventTriggerAuth_basic(t *testing.T) {
204201
}
205202

206203
func TestAccConfigRSEventTriggerAuth_eventProcessor(t *testing.T) {
207-
SkipTestForCI(t)
208204
var (
209205
resourceName = "mongodbatlas_event_trigger.test"
210206
projectID = os.Getenv("MONGODB_ATLAS_PROJECT_ID")
@@ -265,7 +261,6 @@ func TestAccConfigRSEventTriggerAuth_eventProcessor(t *testing.T) {
265261
}
266262

267263
func TestAccConfigRSEventTriggerSchedule_basic(t *testing.T) {
268-
SkipTestForCI(t)
269264
var (
270265
resourceName = "mongodbatlas_event_trigger.test"
271266
projectID = os.Getenv("MONGODB_ATLAS_PROJECT_ID")
@@ -321,7 +316,6 @@ func TestAccConfigRSEventTriggerSchedule_basic(t *testing.T) {
321316
}
322317

323318
func TestAccConfigRSEventTriggerSchedule_eventProcessor(t *testing.T) {
324-
SkipTestForCI(t)
325319
var (
326320
resourceName = "mongodbatlas_event_trigger.test"
327321
projectID = os.Getenv("MONGODB_ATLAS_PROJECT_ID")
@@ -379,7 +373,6 @@ func TestAccConfigRSEventTriggerSchedule_eventProcessor(t *testing.T) {
379373
}
380374

381375
func TestAccConfigRSEventTriggerFunction_basic(t *testing.T) {
382-
SkipTestForCI(t)
383376
var (
384377
resourceName = "mongodbatlas_event_trigger.test"
385378
projectID = os.Getenv("MONGODB_ATLAS_PROJECT_ID")

0 commit comments

Comments
 (0)