update rspec 3

Author: chamnap

Gemfile

@@ -1,14 +1,15 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
-gem "bundler",          ">= 1.7"
-gem "rake",             "~> 10.2.2"
-gem "rspec",            "~> 2.14.1"
-gem "pry",              "~> 0.9.12.6"
-gem "simplecov",        "~> 0.8.2"
-gem "coveralls",        "~> 0.7.0", require: false
-gem "codeclimate-test-reporter"
-gem "ammeter",          "~> 1.0.0"
-gem "railties"
+gem 'bundler',          '>= 1.7'
+gem 'rake',             '~> 10.2.2'
+gem 'rspec',            '~> 3.1.0'
+gem 'guard-rspec',      '~> 4.5.0'
+gem 'pry',              '~> 0.9.12.6'
+gem 'simplecov',        '~> 0.8.2'
+gem 'coveralls',        '~> 0.7.0', require: false
+gem 'codeclimate-test-reporter'
+gem 'ammeter',          '~> 1.1.2'
+gem 'railties'
 
 # Specify your gem's dependencies in mongoid-observers.gemspec
 gemspec

Guardfile

@@ -0,0 +1,77 @@
+# A sample Guardfile
+# More info at https://github.com/guard/guard#readme
+
+## Uncomment and set this to only include directories you want to watch
+# directories %w(app lib config test spec feature)
+
+## Uncomment to clear the screen before every task
+# clearing :on
+
+## Guard internally checks for changes in the Guardfile and exits.
+## If you want Guard to automatically start up again, run guard in a
+## shell loop, e.g.:
+##
+##  $ while bundle exec guard; do echo "Restarting Guard..."; done
+##
+## Note: if you are using the `directories` clause above and you are not
+## watching the project directory ('.'), the you will want to move the Guardfile
+## to a watched dir and symlink it back, e.g.
+#
+#  $ mkdir config
+#  $ mv Guardfile config/
+#  $ ln -s config/Guardfile .
+#
+# and, you'll have to watch "config/Guardfile" instead of "Guardfile"
+
+# Note: The cmd option is now required due to the increasing number of ways
+#       rspec may be run, below are examples of the most common uses.
+#  * bundler: 'bundle exec rspec'
+#  * bundler binstubs: 'bin/rspec'
+#  * spring: 'bin/rspec' (This will use spring if running and you have
+#                          installed the spring binstubs per the docs)
+#  * zeus: 'zeus rspec' (requires the server to be started separately)
+#  * 'just' rspec: 'rspec'
+
+guard :rspec, cmd: "bundle exec rspec" do
+  require "guard/rspec/dsl"
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  # Feel free to open issues for suggestions and improvements
+
+  # RSpec files
+  rspec = dsl.rspec
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+  watch(rspec.spec_files)
+
+  # Ruby files
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+
+  # Rails files
+  rails = dsl.rails(view_extensions: %w(erb haml slim))
+  dsl.watch_spec_files_for(rails.app_files)
+  dsl.watch_spec_files_for(rails.views)
+
+  watch(rails.controllers) do |m|
+    [
+      rspec.spec.("routing/#{m[1]}_routing"),
+      rspec.spec.("controllers/#{m[1]}_controller"),
+      rspec.spec.("acceptance/#{m[1]}")
+    ]
+  end
+
+  # Rails config changes
+  watch(rails.spec_helper)     { rspec.spec_dir }
+  watch(rails.routes)          { "#{rspec.spec_dir}/routing" }
+  watch(rails.app_controller)  { "#{rspec.spec_dir}/controllers" }
+
+  # Capybara features specs
+  watch(rails.view_dirs)     { |m| rspec.spec.("features/#{m[1]}") }
+
+  # Turnip features and steps
+  watch(%r{^spec/acceptance/(.+)\.feature$})
+  watch(%r{^spec/acceptance/steps/(.+)_steps\.rb$}) do |m|
+    Dir[File.join("**/#{m[1]}.feature")][0] || "spec/acceptance"
+  end
+end

spec/mongoid/observer_spec.rb

@@ -11,7 +11,7 @@
   end
 
   it "is an instance of an active model observer" do
-    ActorObserver.instance.should be_a_kind_of(ActiveModel::Observer)
+    expect(ActorObserver.instance).to be_a_kind_of(ActiveModel::Observer)
   end
 
   context "when the oberserver observes a different class" do
@@ -27,7 +27,7 @@ class BandObserver < Mongoid::Observer
     end
 
     it "returns the proper observed classes" do
-      BandObserver.observed_classes.should eq([ Record ])
+      expect(BandObserver.observed_classes).to eq([ Record ])
     end
   end
 
@@ -52,7 +52,7 @@ class BandObserver < Mongoid::Observer
       end
 
       it "contains the updated value in the observer" do
-        phone.number_in_observer.should eq("0152-2222-2222")
+        expect(phone.number_in_observer).to eq("0152-2222-2222")
       end
     end
   end
@@ -68,7 +68,7 @@ class BandObserver < Mongoid::Observer
     end
 
     it "observes descendent class" do
-      observer.last_after_create_record.try(:name).should eq(actress.name)
+      expect(observer.last_after_create_record.try(:name)).to eq(actress.name)
     end
   end
 
@@ -84,7 +84,7 @@ class BandObserver < Mongoid::Observer
 
     it "does not fire the observer" do
       Actor.observers.disable(:all) do
-        actor and observer.last_after_create_record.should_not eq(actor)
+        actor and expect(observer.last_after_create_record).not_to eq(actor)
       end
     end
   end
@@ -101,7 +101,7 @@ class BandObserver < Mongoid::Observer
 
     it "does not fire the observer" do
       Mongoid.observers.disable(:all) do
-        actor and observer.last_after_create_record.should_not eq(actor)
+        actor and expect(observer.last_after_create_record).not_to eq(actor)
       end
     end
   end
@@ -113,15 +113,15 @@ class BandObserver < Mongoid::Observer
     end
 
     it "observes after initialize" do
-      recorder.last_callback.should eq(:after_initialize)
+      expect(recorder.last_callback).to eq(:after_initialize)
     end
 
     it "calls after initialize once" do
-      recorder.call_count[:after_initialize].should eq(1)
+      expect(recorder.call_count[:after_initialize]).to eq(1)
     end
 
     it "contains the model of the callback" do
-      recorder.last_record[:after_initialize].should eq(actor)
+      expect(recorder.last_record[:after_initialize]).to eq(actor)
     end
   end
 
@@ -139,11 +139,11 @@ class BandObserver < Mongoid::Observer
       :around_save ].each do |callback|
 
       it "observes #{callback}" do
-        recorder.call_count[callback].should eq(1)
+        expect(recorder.call_count[callback]).to eq(1)
       end
 
       it "contains the model of the callback" do
-        recorder.last_record[callback].should eq(actor)
+        expect(recorder.last_record[callback]).to eq(actor)
       end
     end
   end
@@ -167,11 +167,11 @@ class BandObserver < Mongoid::Observer
       end
 
       it "observes #{callback}" do
-        recorder.call_count[callback].should eq(1)
+        expect(recorder.call_count[callback]).to eq(1)
       end
 
       it "contains the model of the callback" do
-        recorder.last_record[callback].should eq(actor)
+        expect(recorder.last_record[callback]).to eq(actor)
       end
     end
   end
@@ -192,11 +192,11 @@ class BandObserver < Mongoid::Observer
       end
 
       it "observes #{callback}" do
-        recorder.call_count[callback].should eq(1)
+        expect(recorder.call_count[callback]).to eq(1)
       end
 
       it "contains the model of the callback" do
-        recorder.last_record[callback].should eq(actor)
+        expect(recorder.last_record[callback]).to eq(actor)
       end
     end
   end
@@ -218,11 +218,11 @@ class BandObserver < Mongoid::Observer
       end
 
       it "observes #{callback}" do
-        recorder.call_count[callback].should eq(1)
+        expect(recorder.call_count[callback]).to eq(1)
       end
 
       it "contains the model of the callback" do
-        recorder.last_record[callback].should eq(actor)
+        expect(recorder.last_record[callback]).to eq(actor)
       end
     end
   end
@@ -241,11 +241,11 @@ class BandObserver < Mongoid::Observer
       end
 
       it "observes #{callback}" do
-        recorder.call_count[callback].should eq(1)
+        expect(recorder.call_count[callback]).to eq(1)
       end
 
       it "contains the model of the callback" do
-        recorder.last_record[callback].should eq(actor)
+        expect(recorder.last_record[callback]).to eq(actor)
       end
     end
   end
@@ -264,11 +264,11 @@ class BandObserver < Mongoid::Observer
       end
 
       it "observes #{callback}" do
-        recorder.call_count[callback].should eq(1)
+        expect(recorder.call_count[callback]).to eq(1)
       end
 
       it "contains the model of the callback" do
-        recorder.last_record[callback].should eq(actor)
+        expect(recorder.last_record[callback]).to eq(actor)
       end
     end
   end
@@ -284,7 +284,7 @@ class BandObserver < Mongoid::Observer
     end
 
     it "notifies the observers once" do
-      actor.after_custom_count.should eq(1)
+      expect(actor.after_custom_count).to eq(1)
     end
   end
 end

spec/spec_helper.rb

@@ -32,7 +32,6 @@
 RSpec.configure do |config|
   config.filter_run focus: true
   config.run_all_when_everything_filtered = true
-  config.treat_symbols_as_metadata_keys_with_true_values = true
 
   config.before(:each) do
     Mongoid.purge!