Unable to get callback argument for mgos_pppos_cmd callback

[suyashmathema]

When I pass a callback argument along with cmd and callback function, I am not able to get the callback argument inside the callback function handler.

When I do this

int a = 1;
int* a_ptr = &a
const struct mgos_pppos_cmd cmds[] = {
   {.cmd = "AT+CMGR", .cb = test_cb, .cb_arg=a_ptr},
   {.cmd = NULL},
};

bool test_cb(void* cb_arg, bool ok, struct mg_str data) {
 //The void pointer cb_arg is not same as a_ptr
}

pppos/src/mgos_pppos.c

Line 689 in 31db8aa

cmd_res = cur_cmd->cb(pd, true, mg_strstrip(sd));

cmd_res = cur_cmd->cb(pd, true, mg_strstrip(sd));

pd is passed instead of cur_cmd->cb_arg
Shouldnt it be the callback argument?

[rojer]

indeed, you should. please send a PR. thank you!