Skip to content

Commit 1294499

Browse files
committed
fix: themes ui list shows clipped when selected or hovered
closes #7318
1 parent 4da82d0 commit 1294499

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

frontend/src/styles/settings.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
.settingsGroup {
5151
display: grid;
5252
gap: 2rem;
53-
overflow: hidden;
5453
&.quickNav {
5554
justify-content: center;
5655
.links {

frontend/src/ts/pages/settings.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -753,26 +753,30 @@ function toggleSettingsGroup(groupName: string): void {
753753

754754
const groupEl = qs(`.pageSettings .settingsGroup.${groupName}`);
755755
if (!groupEl?.hasClass("slideup")) {
756-
groupEl?.animate({
756+
groupEl?.setStyle({ overflow: "hidden" })?.animate({
757757
height: 0,
758758
duration: 250,
759759
onComplete: () => {
760-
groupEl?.hide();
760+
groupEl
761+
?.hide()
762+
.setStyle({ height: "", overflow: "" })
763+
.addClass("slideup");
761764
},
762765
});
763-
groupEl?.addClass("slideup");
764766
$(`.pageSettings .sectionGroupTitle[group=${groupName}]`).addClass(
765767
"rotateIcon",
766768
);
767769
} else {
768770
groupEl?.show();
769-
groupEl?.setStyle({ height: "" });
771+
groupEl?.setStyle({ height: "", overflow: "hidden" });
770772
const height = groupEl.getOffsetHeight();
771773
groupEl?.animate({
772774
height: [0, height],
773775
duration: 250,
776+
onComplete: () => {
777+
groupEl?.setStyle({ height: "", overflow: "" }).removeClass("slideup");
778+
},
774779
});
775-
groupEl?.removeClass("slideup");
776780
$(`.pageSettings .sectionGroupTitle[group=${groupName}]`).removeClass(
777781
"rotateIcon",
778782
);

0 commit comments

Comments
 (0)