Skip to content

Commit 2908331

Browse files
authored
fix(zen): remove input length check to prevent jump to hidden line (@byseif21, @nadalaba) (#6714)
Closes #6697
1 parent ee02bee commit 2908331

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

frontend/src/ts/controllers/input-controller.ts

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -731,10 +731,19 @@ async function handleChar(
731731
//stop the word jump by slicing off the last character, update word again
732732
// dont do it in replace typos, because it might trigger in the middle of a wrd
733733
// when using non monospace fonts
734+
/**
735+
* NOTE: this input length > 1 guard, added in commit bc94a64,
736+
* aimed to prevent some input blocking issue after test restarts.
737+
*
738+
* This check was found to cause a jump to a hidden 3rd line bug in zen mode (#6697)
739+
* So commented due to the zen bug and the original issue not being reproducible,
740+
*
741+
* REVISIT this logic if any INPUT or WORD JUMP issues reappear.
742+
*/
734743
if (
735744
activeWordTopBeforeJump < newActiveTop &&
736-
!TestUI.lineTransition &&
737-
TestInput.input.current.length > 1
745+
!TestUI.lineTransition
746+
// TestInput.input.current.length > 1
738747
) {
739748
if (Config.mode === "zen" || Config.indicateTypos === "replace") {
740749
if (!Config.showAllLines) void TestUI.lineJump(activeWordTopBeforeJump);

0 commit comments

Comments
 (0)