improve function type

removes unnecessary type casts

Author: Miodec

frontend/src/ts/utils/url-handler.ts

@@ -152,8 +152,7 @@ export function loadTestSettingsFromUrl(getOverride?: string): void {
   let de: SharedTestSettings;
   try {
     const decompressed = decompressFromURI(getValue) ?? "";
-    const parsed = parseJsonWithSchema(decompressed, TestSettingsSchema);
-    de = parsed as SharedTestSettings; // Assign after refinement
+    de = parseJsonWithSchema(decompressed, TestSettingsSchema);
   } catch (e) {
     console.error("Failed to parse test settings:", e);
     Notifications.add(

packages/util/src/json.ts

@@ -1,16 +1,20 @@
-import { ZodError, ZodIssue, ZodSchema } from "zod";
+import { z, ZodError, ZodIssue } from "zod";
 
 /**
  * Parse a JSON string into an object and validate it against a schema
  * @param json  JSON string
  * @param schema  Zod schema to validate the JSON against
  * @returns  The parsed JSON object
  */
-export function parseWithSchema<T>(json: string, schema: ZodSchema<T>): T {
+export function parseWithSchema<T extends z.ZodTypeAny>(
+  json: string,
+  schema: T
+): z.infer<T> {
   try {
     const jsonParsed = JSON.parse(json) as unknown;
-    const zodParsed = schema.parse(jsonParsed);
-    return zodParsed;
+    // hits is fine to ignore
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-return
+    return schema.parse(jsonParsed) as z.infer<T>;
   } catch (error) {
     if (error instanceof ZodError) {
       throw new Error(error.issues.map(prettyErrorMessage).join("\n"));