Skip to content

Commit d729c28

Browse files
committed
make sure screenshot.css is a separate file
1 parent 9b9b0fe commit d729c28

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

frontend/src/ts/test/test-screenshot.ts

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,14 @@ import { getTheme } from "../signals/theme";
1616
let revealReplay = false;
1717
let revertCookie = false;
1818

19-
const screenshotCssHref = qsr("#screeenshotCss").getAttribute("href") as string;
20-
const vendorCss = qsr("#vendorCss");
19+
//we can select the screenshotCss link on dev by id or on prod by the href
20+
const screenshotCss =
21+
qs("#screeenshotCss") ?? qsr('link[href^="/css/screenshot"]');
22+
const screenshotCssHref = screenshotCss.getAttribute("href") as string;
23+
//we can select the vendorCss link on dev by id or on prod by the href
24+
const vendorCss = qs("#vendorCss") ?? qsr('link[href^="/css/vendor"]');
2125
const vendorCssHref = vendorCss.getAttribute("href") as string;
22-
qsr("#screeenshotCss").remove();
26+
screenshotCss.remove();
2327

2428
function revert(): void {
2529
setIsScreenshotting(false);
@@ -48,7 +52,7 @@ function revert(): void {
4852
fb.functions.applyGlobalCSS();
4953
}
5054

51-
qsr("#vendorCss").setAttribute("href", vendorCssHref);
55+
vendorCss.setAttribute("href", vendorCssHref);
5256
}
5357

5458
let firefoxClipboardNotificationShown = false;
@@ -111,7 +115,6 @@ async function generateCanvas(): Promise<HTMLCanvasElement | null> {
111115
qsa(".highlightContainer")?.hide();
112116

113117
// Wait for stylesheet to load
114-
const vendorCss = qsr("#vendorCss");
115118
await new Promise<void>((resolve) => {
116119
vendorCss.native.addEventListener("load", () => resolve(), { once: true });
117120
vendorCss.setAttribute("href", screenshotCssHref);

frontend/vite.config.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,7 @@ function getBuildOptions({
227227
security: path.resolve(__dirname, "src/security-policy.html"),
228228
terms: path.resolve(__dirname, "src/terms-of-service.html"),
229229
404: path.resolve(__dirname, "src/404.html"),
230+
screenshotCss: path.resolve(__dirname, "src/styles/screenshot.scss"), //needs to be a separate file
230231
},
231232
output: {
232233
assetFileNames: (assetInfo) => {

0 commit comments

Comments
 (0)