Fixed the generated C# for pure virtual functions with default arguments.

Signed-off-by: Dimitar Dobrev <[email protected]>

Author: ddobrev

src/Generator/Driver.cs

@@ -251,12 +251,12 @@ public void SetupPasses(ILibrary library)
 
             if (Options.IsCSharpGenerator)
             {
-                TranslationUnitPasses.AddPass(new GenerateAbstractImplementationsPass());
                 if (Options.GenerateDefaultValuesForArguments)
                 {
                     TranslationUnitPasses.AddPass(new FixDefaultParamValuesOfOverridesPass());
                     TranslationUnitPasses.AddPass(new HandleDefaultParamValuesPass());
                 }
+                TranslationUnitPasses.AddPass(new GenerateAbstractImplementationsPass());
                 TranslationUnitPasses.AddPass(new MultipleInheritancePass());
             }
             TranslationUnitPasses.AddPass(new DelegatesPass());

src/Generator/Passes/GenerateAbstractImplementationsPass.cs

@@ -64,7 +64,8 @@ private static Class AddInternalImplementation(Class @class)
                         Namespace = internalImpl,
                         OriginalFunction = abstractMethod,
                         IsPure = false,
-                        SynthKind = FunctionSynthKind.AbstractImplCall
+                        SynthKind = abstractMethod.SynthKind == FunctionSynthKind.DefaultValueOverload ?
+                            FunctionSynthKind.DefaultValueOverload : FunctionSynthKind.AbstractImplCall
                     };
                 impl.OverriddenMethods.Clear();
                 impl.OverriddenMethods.Add(abstractMethod);
@@ -120,7 +121,7 @@ private static IEnumerable<Method> GetRelevantAbstractMethods(Class @class)
                     }
                     else
                     {
-                        abstractMethods.RemoveAt(i);                        
+                        abstractMethods.RemoveAt(i);
                     }
                 }
             }

tests/CSharp/CSharp.h

@@ -444,6 +444,12 @@ class DLL_API MethodsWithDefaultValues : public Quux
     Foo m_foo;
 };
 
+class DLL_API HasPureVirtualWithDefaultArg
+{
+public:
+    virtual void pureVirtualWithDefaultArg(Foo* foo = nullptr) = 0;
+};
+
 class DLL_API HasOverridesWithChangedAccessBase
 {
 public: