Skip to content

Commit 5cb683a

Browse files
committed
Normalize visiting overloads to be virtual.
1 parent b358b32 commit 5cb683a

File tree

2 files changed

+175
-176
lines changed

2 files changed

+175
-176
lines changed

src/AST/ASTVisitor.cs

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ public interface IAstVisited
1212
bool AlreadyVisited(Type type);
1313
}
1414

15-
public interface IAstVisitor<out T> : ITypeVisitor<T>,
16-
IDeclVisitor<T>, IStmtVisitor<T>
15+
public interface IAstVisitor<out T> : ITypeVisitor<T>, IDeclVisitor<T>, IStmtVisitor<T>
1716
{
1817
AstVisitorOptions VisitOptions { get; }
1918
}
@@ -307,17 +306,17 @@ public virtual bool VisitPackExpansionType(PackExpansionType packExpansionType,
307306
return true;
308307
}
309308

310-
public bool VisitUnaryTransformType(UnaryTransformType unaryTransformType, TypeQualifiers quals)
309+
public virtual bool VisitUnaryTransformType(UnaryTransformType unaryTransformType, TypeQualifiers quals)
311310
{
312311
return true;
313312
}
314313

315-
public bool VisitUnresolvedUsingType(UnresolvedUsingType unresolvedUsingType, TypeQualifiers quals)
314+
public virtual bool VisitUnresolvedUsingType(UnresolvedUsingType unresolvedUsingType, TypeQualifiers quals)
316315
{
317316
return true;
318317
}
319318

320-
public bool VisitVectorType(VectorType vectorType, TypeQualifiers quals)
319+
public virtual bool VisitVectorType(VectorType vectorType, TypeQualifiers quals)
321320
{
322321
return true;
323322
}
@@ -443,7 +442,7 @@ public virtual bool VisitProperty(Property property)
443442
return true;
444443
}
445444

446-
public bool VisitFriend(Friend friend)
445+
public virtual bool VisitFriend(Friend friend)
447446
{
448447
if (!VisitDeclaration(friend))
449448
return false;
@@ -480,7 +479,7 @@ public virtual bool VisitParameterDecl(Parameter parameter)
480479
return parameter.Type.Visit(this, parameter.QualifiedType.Qualifiers);
481480
}
482481

483-
public bool VisitTypedefNameDecl(TypedefNameDecl typedef)
482+
public virtual bool VisitTypedefNameDecl(TypedefNameDecl typedef)
484483
{
485484
if (!VisitDeclaration(typedef))
486485
return false;
@@ -493,7 +492,7 @@ public virtual bool VisitTypedefDecl(TypedefDecl typedef)
493492
return VisitTypedefNameDecl(typedef);
494493
}
495494

496-
public bool VisitTypeAliasDecl(TypeAlias typeAlias)
495+
public virtual bool VisitTypeAliasDecl(TypeAlias typeAlias)
497496
{
498497
return VisitTypedefNameDecl(typeAlias);
499498
}
@@ -584,7 +583,7 @@ public virtual bool VisitFunctionTemplateSpecializationDecl(FunctionTemplateSpec
584583
return specialization.SpecializedFunction.Visit(this);
585584
}
586585

587-
public bool VisitVarTemplateDecl(VarTemplate template)
586+
public virtual bool VisitVarTemplateDecl(VarTemplate template)
588587
{
589588
if (!VisitDeclaration(template))
590589
return false;
@@ -600,7 +599,7 @@ public bool VisitVarTemplateDecl(VarTemplate template)
600599
return true;
601600
}
602601

603-
public bool VisitVarTemplateSpecializationDecl(VarTemplateSpecialization specialization)
602+
public virtual bool VisitVarTemplateSpecializationDecl(VarTemplateSpecialization specialization)
604603
{
605604
return VisitVariableDecl(specialization);
606605
}
@@ -664,7 +663,7 @@ public virtual bool VisitEvent(Event @event)
664663
return true;
665664
}
666665

667-
public bool VisitTemplateTemplateParameterDecl(TemplateTemplateParameter templateTemplateParameter)
666+
public virtual bool VisitTemplateTemplateParameterDecl(TemplateTemplateParameter templateTemplateParameter)
668667
{
669668
if (!VisitDeclaration(templateTemplateParameter))
670669
return false;
@@ -683,15 +682,15 @@ public virtual bool VisitTemplateParameterDecl(TypeTemplateParameter templatePar
683682
return true;
684683
}
685684

686-
public bool VisitNonTypeTemplateParameterDecl(NonTypeTemplateParameter nonTypeTemplateParameter)
685+
public virtual bool VisitNonTypeTemplateParameterDecl(NonTypeTemplateParameter nonTypeTemplateParameter)
687686
{
688687
if (!VisitDeclaration(nonTypeTemplateParameter))
689688
return false;
690689

691690
return true;
692691
}
693692

694-
public bool VisitUnresolvedUsingDecl(UnresolvedUsingTypename unresolvedUsingTypename)
693+
public virtual bool VisitUnresolvedUsingDecl(UnresolvedUsingTypename unresolvedUsingTypename)
695694
{
696695
if (!VisitDeclaration(unresolvedUsingTypename))
697696
return false;

0 commit comments

Comments
 (0)