Generate valid C# for template parameters with a default value

Signed-off-by: Dimitar Dobrev <[email protected]>

Author: ddobrev

src/Generator/Passes/HandleDefaultParamValuesPass.cs

@@ -46,7 +46,7 @@ public override bool VisitFunctionDecl(Function function)
                 Type type = parameter.Type.Desugar(resolveTemplateSubstitution: false);
                 type = (type.GetFinalPointee() ?? type).Desugar(
                     resolveTemplateSubstitution: false);
-                if (type is TemplateParameterSubstitutionType)
+                if (type is TemplateParameterSubstitutionType || type.IsDependent)
                 {
                     parameter.DefaultArgument = null;
                     continue;

tests/CSharp/CSharp.Tests.cs

@@ -951,7 +951,7 @@ public void TestExtensionsOfSpecializationsAsSecondaryBases()
     [Test]
     public void TestFieldWithDependentPointerType()
     {
-        using (var dependentPointerFields = new DependentPointerFields<float>())
+        using (var dependentPointerFields = new DependentPointerFields<float>(0))
         {
         }
     }

tests/CSharp/CSharpTemplates.h

@@ -240,15 +240,15 @@ template <typename T>
 class DLL_API DependentPointerFields
 {
 public:
-    DependentPointerFields();
+    DependentPointerFields(T t = 0);
     ~DependentPointerFields();
     T property();
     T takeField(T t);
     T* field;
 };
 
 template <typename T>
-DependentPointerFields<T>::DependentPointerFields()
+DependentPointerFields<T>::DependentPointerFields(T t)
 {
 }