Don't wrap trivial constructors and destructors

Signed-off-by: Dimitar Dobrev <[email protected]>

Author: ddobrev

src/AST/FunctionExtensions.cs

@@ -92,5 +92,17 @@ public static bool CanOverride(this Method @override, Method method)
                     ParameterTypeComparer.Instance)) ||
                 (@override.IsDestructor && method.IsDestructor && method.IsVirtual);
         }
+
+        public static bool NeedsSymbol(this Method method)
+        {
+            Class @class = (Class) method.Namespace;
+            // virtual functions cannot really be inlined and
+            // we don't need their symbols anyway as we call them through the v-table
+            return (!method.IsVirtual && !method.IsSynthetized &&
+                !method.IsDefaultConstructor && !method.IsCopyConstructor && !method.IsDestructor) ||
+                (method.IsDefaultConstructor && @class.HasNonTrivialDefaultConstructor) ||
+                (method.IsCopyConstructor && @class.HasNonTrivialCopyConstructor) ||
+                (method.IsDestructor && !method.IsVirtual && @class.HasNonTrivialDestructor);
+        }
     }
 }

src/CppParser/Bindings/CSharp/i686-apple-darwin12.4.0/CppSharp.CppParser-symbols.cpp

@@ -655,7 +655,8 @@ private void GatherClassInternalFunctions(Class @class, bool includeCtors,
 
             foreach (var method in @class.Methods)
             {
-                if (!method.IsGenerated || ASTUtils.CheckIgnoreMethod(method))
+                if (!method.IsGenerated || ASTUtils.CheckIgnoreMethod(method) ||
+                    (!method.NeedsSymbol() && !method.IsOperator))
                     continue;
 
                 if (method.IsConstructor)

src/CppParser/Bindings/CSharp/i686-pc-win32-msvc/CppSharp.CppParser-symbols.cpp

@@ -83,9 +83,7 @@ private bool CheckForSymbol(Declaration decl)
             var mangledDecl = decl as IMangledDecl;
             var method = decl as Method;
             if (decl.IsGenerated && mangledDecl != null &&
-                // virtual functions cannot really be inlined and
-                // we don't need their symbols anyway as we call them through the v-table
-                !(method != null && (method.IsVirtual || method.IsSynthetized)) &&
+                method?.NeedsSymbol() == true &&
                 !VisitMangledDeclaration(mangledDecl))
             {
                 decl.ExplicitlyIgnore();

src/CppParser/Bindings/CSharp/x86_64-apple-darwin12.4.0/CppSharp.CppParser-symbols.cpp

@@ -125,6 +125,7 @@ private bool NeedsSymbol(Function function)
             var method = function as Method;
             bool isInImplicitSpecialization;
             var declarationContext = function.Namespace;
+            var @class = declarationContext as Class;
             do
             {
                 isInImplicitSpecialization =
@@ -138,8 +139,7 @@ declarationContext is ClassTemplateSpecialization specialization &&
                 !function.IsDependent && !function.IsPure && function.Namespace.IsGenerated &&
                 (!string.IsNullOrEmpty(function.Body) ||
                  isInImplicitSpecialization || function.IsImplicit) &&
-                // we don't need symbols for virtual functions anyway
-                (method == null || (!method.IsVirtual && !method.IsSynthetized)) &&
+                (method?.NeedsSymbol() != false) &&
                 // we cannot handle nested anonymous types
                 (!(function.Namespace is Class) || !string.IsNullOrEmpty(function.Namespace.OriginalName)) &&
                 !Context.Symbols.FindLibraryBySymbol(function.Mangled, out _);