Fix rename pass not handling some declarations due to early return.

tritao · tritao · commit a13a1e7e8870 · 2020-12-07T02:22:58.000Z
diff --git a/src/Generator/Passes/RenamePass.cs b/src/Generator/Passes/RenamePass.cs
@@ -141,7 +141,8 @@ public override bool VisitDeclaration(Declaration decl)
             if (decl.Name == null)
                 return true;
 
-            return Rename(decl);
+            Rename(decl);
+            return true;
         }
 
         private bool Rename(Declaration decl)
@@ -345,6 +346,8 @@ public override bool Rename(Declaration decl, out string newName)
             newName = null;
             return false;
         }
+
+        public override string ToString() => $"RegexRenamePass: {Pattern}";
     }
 
     public enum RenameCasePattern

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,8 @@ public override bool VisitDeclaration(Declaration decl)`
`141`	`141`	`if (decl.Name == null)`
`142`	`142`	`return true;`
`143`	`143`
`144`		`- return Rename(decl);`
	`144`	`+ Rename(decl);`
	`145`	`+ return true;`
`145`	`146`	`}`
`146`	`147`
`147`	`148`	`private bool Rename(Declaration decl)`
`@@ -345,6 +346,8 @@ public override bool Rename(Declaration decl, out string newName)`
`345`	`346`	`newName = null;`
`346`	`347`	`return false;`
`347`	`348`	`}`
	`349`	`+`
	`350`	`+ public override string ToString() => $"RegexRenamePass: {Pattern}";`
`348`	`351`	`}`
`349`	`352`
`350`	`353`	`public enum RenameCasePattern`