Give unique names to exported inlined functions

This way a precise exception is thrown when the birdge tries calling into a wrong version of the library with exported symbols.

Signed-off-by: Dimitar Dobrev <[email protected]>

Author: ddobrev

src/Generator/Passes/SymbolsCodeGenerator.cs

@@ -70,13 +70,27 @@ private string GetExporting()
                 "__declspec(dllexport) " : string.Empty;
         }
 
-        private string GetWrapper(Module module)
+        private string GetWrapper(Function function)
         {
-            var symbolsLibraryName = new StringBuilder(module.SymbolsLibraryName);
-            for (int i = 0; i < symbolsLibraryName.Length; i++)
-                if (!char.IsLetterOrDigit(symbolsLibraryName[i]))
-                    symbolsLibraryName[i] = '_';
-            return $"{symbolsLibraryName}{++functionCount}";
+            if (function is Method method && (method.IsConstructor || method.IsDestructor))
+            {
+                var nameBuilder = new StringBuilder(method.USR);
+                for (int i = 0; i < nameBuilder.Length; i++)
+                    if (!char.IsLetterOrDigit(nameBuilder[i]) &&
+                        nameBuilder[i] != '_')
+                    {
+                        if (nameBuilder[i] == '&')
+                            nameBuilder.Insert(i + 1, '_');
+                        nameBuilder[i] = '_';
+                    }
+                string @class = function.Namespace.Name;
+                nameBuilder.Replace("c__S_", string.Empty).Replace(
+                    $"{@class}_F_", $"{@class}_").TrimUnderscores();
+                if (function.IsOperator)
+                    nameBuilder.Append(function.OperatorKind);
+                return nameBuilder.ToString();
+            }
+            return $"_{functionCount++}";
         }
 
         private static string GetDerivedType(string @namespace, string wrapper)
@@ -86,7 +100,7 @@ private static string GetDerivedType(string @namespace, string wrapper)
 
         private void WrapConstructor(Method method)
         {
-            string wrapper = GetWrapper(method.TranslationUnit.Module);
+            string wrapper = GetWrapper(method);
             if (Options.CheckSymbols)
             {
                 method.Mangled = wrapper;
@@ -144,7 +158,7 @@ private string CastIfRVReference(Parameter p)
 
         private void WrapDestructor(Method method)
         {
-            string wrapper = GetWrapper(method.TranslationUnit.Module);
+            string wrapper = GetWrapper(method);
             if (Options.CheckSymbols)
             {
                 method.Mangled = wrapper;
@@ -178,7 +192,7 @@ private void WrapDestructor(Method method)
 
         private void TakeFunctionAddress(Function function)
         {
-            string wrapper = GetWrapper(function.TranslationUnit.Module);
+            string wrapper = GetWrapper(function);
             string @namespace = function.Namespace.Visit(cppTypePrinter);
             if (function.Access == AccessSpecifier.Protected)
             {