Extract and re-use GetIncludePath across multiple generators.

Author: tritao

src/Generator/Generators/C/CppHeaders.cs

@@ -96,8 +96,10 @@ public void GenerateIncludeForwardRefs(TranslationUnit unit)
                 if (typeRefUnit != null && !typeRefUnit.IsDeclared)
                     continue;
 
-                if(!string.IsNullOrEmpty(include.File) && include.InHeader)
-                    includes.Add(include.ToString());
+                if (!string.IsNullOrEmpty(include.File) && include.InHeader)
+                {
+                    includes.Add(Context.Options.GetIncludePath(typeRefUnit));
+                }
             }
 
             foreach (var include in includes)

src/Generator/Generators/C/CppSources.cs

@@ -28,14 +28,9 @@ public override void Process()
         {
             GenerateFilePreamble(CommentKind.BCPL);
 
-            var file = Path.GetFileNameWithoutExtension(TranslationUnit.FileName)
-                .Replace('\\', '/');
-
-            if (Context.Options.GenerateName != null)
-                file = Context.Options.GenerateName(TranslationUnit);
-
             PushBlock(BlockKind.Includes);
-            WriteLine("#include \"{0}.h\"", file);
+            var file = Context.Options.GetIncludePath(TranslationUnit);
+            WriteLine($"#include \"{file}\"");
             GenerateForwardReferenceHeaders();
 
             NewLine();

src/Generator/Generators/C/QuickJS/QuickJSModule.cs

@@ -105,6 +105,7 @@ public override void Process()
         public static string GetIncludeFileName(BindingContext context,
             TranslationUnit unit)
         {
+            // TODO: Replace with GetIncludePath
             string file;
             if (context.Options.GenerateName != null)
                 file = context.Options.GenerateName(unit);

src/Generator/Generators/CLI/CLISources.cs

@@ -27,14 +27,9 @@ public override void Process()
         {
             GenerateFilePreamble(CommentKind.BCPL);
 
-            var file = Path.GetFileNameWithoutExtension(TranslationUnit.FileName)
-                .Replace('\\', '/');
-
-            if (Context.Options.GenerateName != null)
-                file = Context.Options.GenerateName(TranslationUnit);
-
             PushBlock(BlockKind.Includes);
-            WriteLine("#include \"{0}.h\"", file);
+            var file = Context.Options.GetIncludePath(TranslationUnit);
+            WriteLine($"#include \"{file}\"");
             GenerateForwardReferenceHeaders();
 
             NewLine();

src/Generator/Generators/CLI/CLITypeReferences.cs

@@ -59,7 +59,7 @@ public CLITypeReference GetTypeReference(Declaration decl)
 
                 @ref.Include = new CInclude
                 {
-                    File = GetIncludePath(translationUnit),
+                    File = DriverOptions.GetIncludePath(translationUnit),
                     TranslationUnit = translationUnit,
                     Kind = translationUnit.IsGenerated ? CInclude.IncludeKind.Quoted : CInclude.IncludeKind.Angled
                 };
@@ -145,22 +145,6 @@ private bool ShouldIncludeTranslationUnit(TranslationUnit unit)
             return !unit.IsSystemHeader && unit.IsValid && !unit.Ignore;
         }
 
-        private string GetIncludePath(TranslationUnit translationUnit)
-        {
-            if (!DriverOptions.UseHeaderDirectories && DriverOptions.GenerateName != null)
-            {
-                var extension = Path.GetExtension(TranslationUnit.FileName);
-                return $"{DriverOptions.GenerateName(translationUnit)}{extension}";
-            }
-            else if (DriverOptions.UseHeaderDirectories)
-            {
-                var path = Path.Combine(translationUnit.FileRelativeDirectory, translationUnit.FileName);
-                return path;
-            }
-
-            return translationUnit.FileName;
-        }
-
         private bool IsBuiltinTypedef(Declaration decl)
         {
             var typedefDecl = decl as TypedefDecl;

src/Generator/Generators/ExtensionMethods.cs

@@ -1,5 +1,6 @@
 using System.Linq;
 using System.Collections.Generic;
+using System.IO;
 using CppSharp.AST;
 using CppSharp.AST.Extensions;
 using CppSharp.Types;
@@ -72,5 +73,21 @@ public static Type GetMappedType(this Type type, TypeMapDatabase typeMaps,
 
             return type.Desugar();
         }
+
+        public static string GetIncludePath(this DriverOptions driverOptions, TranslationUnit translationUnit)
+        {
+            if (driverOptions.GenerateName != null)
+            {
+                var extension = Path.GetExtension(translationUnit.FileName);
+                return $"{driverOptions.GenerateName(translationUnit)}{extension}";
+            }
+            else if (driverOptions.UseHeaderDirectories)
+            {
+                var path = Path.Combine(translationUnit.FileRelativeDirectory, translationUnit.FileName);
+                return path;
+            }
+
+            return translationUnit.FileName;
+        }
     }
 }