Fixed naming edge case in GenerateProperties.GetReadWritePropertyName.

tritao · tritao · commit f62b6f8d2d7e · 2019-02-20T01:45:52.000Z
diff --git a/src/Generator/Passes/GetterSetterToPropertyPass.cs b/src/Generator/Passes/GetterSetterToPropertyPass.cs
@@ -121,7 +121,8 @@ private void GenerateProperties(IEnumerable<Method> settersToUse, bool readOnly)
             private static string GetReadWritePropertyName(INamedDecl getter, string afterSet)
             {
                 string name = GetPropertyName(getter.Name);
-                if (name != afterSet && name.StartsWith("is", StringComparison.Ordinal))
+                if (name != afterSet && name.StartsWith("is", StringComparison.Ordinal) &&
+                    name != "is")
                 {
                     name = char.ToLowerInvariant(name[2]) + name.Substring(3);
                 }

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,8 @@ private void GenerateProperties(IEnumerable<Method> settersToUse, bool readOnly)`
`121`	`121`	`private static string GetReadWritePropertyName(INamedDecl getter, string afterSet)`
`122`	`122`	`{`
`123`	`123`	`string name = GetPropertyName(getter.Name);`
`124`		`- if (name != afterSet && name.StartsWith("is", StringComparison.Ordinal))`
	`124`	`+ if (name != afterSet && name.StartsWith("is", StringComparison.Ordinal) &&`
	`125`	`+ name != "is")`
`125`	`126`	`{`
`126`	`127`	`name = char.ToLowerInvariant(name[2]) + name.Substring(3);`
`127`	`128`	`}`