Skip to content

Commit f8ccbb8

Browse files
mattparkstritao
authored andcommitted
Added parameter index to managed marshal variables
1 parent 9ef1967 commit f8ccbb8

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

src/Generator/Types/Std/Stdlib.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ public override void CSharpMarshalToManaged(CSharpMarshalContext ctx)
9898
var c_str = basicString.Methods.First(m => m.OriginalName == "c_str");
9999
var typePrinter = new CSharpTypePrinter(ctx.Context);
100100
string qualifiedBasicString = GetQualifiedBasicString(basicString);
101-
const string varBasicString = "__basicStringRet";
101+
string varBasicString = $"__basicStringRet{ctx.ParameterIndex}";
102102
ctx.Before.WriteLine($@"var {varBasicString} = {
103103
basicString.Visit(typePrinter)}.{Helpers.CreateInstanceIdentifier}({
104104
ctx.ReturnVarName});");
@@ -109,7 +109,7 @@ public override void CSharpMarshalToManaged(CSharpMarshalContext ctx)
109109
}
110110
else
111111
{
112-
const string varString = "__stringRet";
112+
string varString = $"__stringRet{ctx.ParameterIndex}";
113113
ctx.Before.WriteLine($@"var {varString} = {
114114
qualifiedBasicString}Extensions.{c_str.Name}({varBasicString});");
115115
ctx.Before.WriteLine($"{varBasicString}.Dispose(false);");

tests/Common/Common.Tests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -804,7 +804,7 @@ public void TestVirtualFuncWithStringParams()
804804
{
805805
using (var VirtFuncWithStringParam = new ImplementsVirtualFunctionsWithStringParams())
806806
{
807-
VirtFuncWithStringParam.PureVirtualFunctionWithStringParams("anyRandomString");
807+
VirtFuncWithStringParam.PureVirtualFunctionWithStringParams("anyRandomString1", "anyRandomString2");
808808
Assert.That(VirtFuncWithStringParam.VirtualFunctionWithStringParam("anyRandomString").Equals(5));
809809
}
810810
}

tests/Common/Common.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -901,7 +901,7 @@ ImplementsVirtualFunctionsWithStringParams::~ImplementsVirtualFunctionsWithStrin
901901
{
902902
}
903903

904-
void ImplementsVirtualFunctionsWithStringParams::PureVirtualFunctionWithStringParams(std::string testString)
904+
void ImplementsVirtualFunctionsWithStringParams::PureVirtualFunctionWithStringParams(std::string testString1, std::string testString2)
905905
{
906906
}
907907

tests/Common/Common.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1336,7 +1336,7 @@ class DLL_API HasVirtualFunctionsWithStringParams
13361336
public:
13371337
HasVirtualFunctionsWithStringParams();
13381338
~HasVirtualFunctionsWithStringParams();
1339-
virtual void PureVirtualFunctionWithStringParams(std::string testString) = 0;
1339+
virtual void PureVirtualFunctionWithStringParams(std::string testString1, std::string testString2) = 0;
13401340
virtual int VirtualFunctionWithStringParam(std::string testString);
13411341
};
13421342

@@ -1345,7 +1345,7 @@ class DLL_API ImplementsVirtualFunctionsWithStringParams : public HasVirtualFunc
13451345
public:
13461346
ImplementsVirtualFunctionsWithStringParams();
13471347
~ImplementsVirtualFunctionsWithStringParams();
1348-
virtual void PureVirtualFunctionWithStringParams(std::string testString);
1348+
virtual void PureVirtualFunctionWithStringParams(std::string testString1, std::string testString2);
13491349
};
13501350

13511351
class DLL_API HasVirtualFunctionWithBoolParams

0 commit comments

Comments
 (0)