Test CustomAllocator debugging configuration fix.#1887
Closed
HenrikAkseliValve wants to merge 1 commit intomono:mainfrom
Closed
Test CustomAllocator debugging configuration fix.#1887HenrikAkseliValve wants to merge 1 commit intomono:mainfrom
HenrikAkseliValve wants to merge 1 commit intomono:mainfrom
Conversation
On Windows 2022 "vector" module deconstructor of the `vector` is the following:
```C++
_CONSTEXPR20 ~vector() noexcept {
_Tidy();
#if _ITERATOR_DEBUG_LEVEL != 0
auto&& _Alproxy = _GET_PROXY_ALLOCATOR(_Alty, _Getal());
_Delete_plain_internal(_Alproxy, _STD exchange(_Mypair._Myval2._Myproxy, nullptr));
#endif // _ITERATOR_DEBUG_LEVEL != 0
}
```
When debugging configuration is enabled, internals here report an error for NamespacesDerived.Native.
A fix is to add Constructor and Copy Constructor to the NamespacesDerived.h `CustomAllocator`.
Windows manual seems to want even more to be defined, but I leave it here.
https://learn.microsoft.com/en-us/cpp/standard-library/allocators?view=msvc-170
Contributor
|
This fix was already merged with #1892. We can close this now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows 2022 "vector" module deconstructor of the
vectoris the following:When debugging configuration is enabled, internals here report an error for NamespacesDerived.Native.
A fix is to add Constructor and Copy Constructor to the NamespacesDerived.h
CustomAllocator. Windows manual seems to want even more to be defined, but I leave it here. https://learn.microsoft.com/en-us/cpp/standard-library/allocators?view=msvc-170