Skip to content

Commit c85c478

Browse files
authored
Move the WASM fix to SkiaSharp (#3088)
1 parent bdc1d88 commit c85c478

File tree

2 files changed

+22
-18
lines changed

2 files changed

+22
-18
lines changed

binding/HarfBuzzSharp.NativeAssets.WebAssembly/buildTransitive/HarfBuzzSharp.targets

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -31,22 +31,4 @@
3131
<NativeFileReference Include="$(HarfBuzzSharpStaticLibraryPath)\3.1.56\$(_HarfBuzzSharpNativeBinaryType)\*.a" Condition="$([MSBuild]::VersionGreaterThanOrEquals($(TargetFrameworkVersion), '9.0'))" />
3232
</ItemGroup>
3333

34-
<!-- Workaround for https://github.com/dotnet/runtime/issues/109289 -->
35-
<Target Name="RuntimeIssue109289_Workaround"
36-
AfterTargets="_BrowserWasmWriteRspForLinking">
37-
<ItemGroup>
38-
<_WasmLinkStepArgs Remove="@(_EmccLinkStepArgs)" />
39-
<_EmccLinkStepArgs Remove="&quot;%(_WasmNativeFileForLinking.Identity)&quot;" />
40-
<_WasmLinkDependencies Remove="@(_WasmNativeFileForLinking)" />
41-
42-
<_SkiaSharpToReorder Include="@(_WasmNativeFileForLinking)" Condition="$([System.String]::Copy('%(FullPath)').Contains('libSkiaSharp.a'))" />
43-
<_WasmNativeFileForLinking Remove="@(_SkiaSharpToReorder)" />
44-
<_WasmNativeFileForLinking Include="@(_SkiaSharpToReorder)" />
45-
46-
<_EmccLinkStepArgs Include="&quot;%(_WasmNativeFileForLinking.Identity)&quot;" />
47-
<_WasmLinkDependencies Include="@(_WasmNativeFileForLinking)" />
48-
<_WasmLinkStepArgs Include="@(_EmccLinkStepArgs)" />
49-
</ItemGroup>
50-
</Target>
51-
5234
</Project>

binding/SkiaSharp.NativeAssets.WebAssembly/buildTransitive/SkiaSharp.targets

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,26 @@
4040
<NativeFileReference Include="$(SkiaSharpStaticLibraryPath)\3.1.56\$(_SkiaSharpNativeBinaryType)\*.a" Condition="$([MSBuild]::VersionGreaterThanOrEquals($(TargetFrameworkVersion), '9.0'))" />
4141
</ItemGroup>
4242

43+
<!-- Workaround for https://github.com/dotnet/runtime/issues/109289 -->
44+
<Target Name="_SkiaSharpRuntimeIssue109289Workaround" AfterTargets="_BrowserWasmWriteRspForLinking">
45+
<ItemGroup>
46+
<!-- Remove the relevant args from the items -->
47+
<_WasmLinkStepArgs Remove="@(_EmccLinkStepArgs)" />
48+
<_EmccLinkStepArgs Remove="&quot;%(_WasmNativeFileForLinking.Identity)&quot;" />
49+
<_WasmLinkDependencies Remove="@(_WasmNativeFileForLinking)" />
50+
51+
<!-- Find the libSkiaSharp binaries -->
52+
<_SkiaSharpToReorder Include="@(_WasmNativeFileForLinking)" Condition="$([System.String]::Copy('%(FullPath)').Contains('libSkiaSharp.a'))" />
53+
54+
<!-- Remove the libSkiaSharp binary and add it back, but at the end -->
55+
<_WasmNativeFileForLinking Remove="@(_SkiaSharpToReorder)" />
56+
<_WasmNativeFileForLinking Include="@(_SkiaSharpToReorder)" />
57+
58+
<!-- Add all the args back -->
59+
<_EmccLinkStepArgs Include="&quot;%(_WasmNativeFileForLinking.Identity)&quot;" />
60+
<_WasmLinkDependencies Include="@(_WasmNativeFileForLinking)" />
61+
<_WasmLinkStepArgs Include="@(_EmccLinkStepArgs)" />
62+
</ItemGroup>
63+
</Target>
64+
4365
</Project>

0 commit comments

Comments
 (0)