-
Notifications
You must be signed in to change notification settings - Fork 591
Open
Labels
Description
Description
SKImageFilter.CreateTile
with (SKRect src, SKRect dst)
overload is useless. It makes a call to overload with input
parameter and passes null to it. However this overload throws ArgumentException
if input is null. Nullability of said overload is also misleading, since it clearly can't be null.
SKImageFilter.CreateTile(src, dst, (SKImageFilter) null);
Code
SkiaSharp/binding/SkiaSharp/SKImageFilter.cs
Lines 321 to 328 in 80d6b59
public static SKImageFilter CreateTile (SKRect src, SKRect dst) => | |
CreateTile (src, dst, null); | |
public static SKImageFilter CreateTile (SKRect src, SKRect dst, SKImageFilter? input) | |
{ | |
_ = input ?? throw new ArgumentNullException (nameof (input)); | |
return GetObject (SkiaApi.sk_imagefilter_new_tile (&src, &dst, input.Handle)); | |
} |
Expected Behavior
No response
Actual Behavior
No response
Version of SkiaSharp
3.116.0 (Current)
Last Known Good Version of SkiaSharp
2.88.9 (Previous)
IDE / Editor
Other (Please indicate in the description)
Platform / Operating System
All
Platform / Operating System Version
No response
Devices
No response
Relevant Screenshots
No response
Relevant Log Output
Code of Conduct
- I agree to follow this project's Code of Conduct
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
New