From 368840a401cb66803e1d1a1696afa823a8a87c47 Mon Sep 17 00:00:00 2001 From: Nick Walker Date: Sat, 4 Jan 2025 11:12:22 -0800 Subject: [PATCH] Test fix for interfaces (pt 1) Avoid Resolve()ing TypeReferences for interfaces before comparing names to see if they're inherited, because GetInheritedInterfaces captures the FullName values prior to Resolve()ing, and Resolve() changes the FullName in the case of generic interfaces --- mdoc/Mono.Documentation/Updater/DocUtils.cs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mdoc/Mono.Documentation/Updater/DocUtils.cs b/mdoc/Mono.Documentation/Updater/DocUtils.cs index 13bfc423..aee12b6e 100644 --- a/mdoc/Mono.Documentation/Updater/DocUtils.cs +++ b/mdoc/Mono.Documentation/Updater/DocUtils.cs @@ -452,9 +452,8 @@ public static IEnumerable GetUserImplementedInterfaces (TypeDefin foreach (var ii in type.Interfaces) { var iface = ii.InterfaceType; - TypeReference lookup = iface.Resolve () ?? iface; - var iname = GetQualifiedTypeName(lookup); + var iname = GetQualifiedTypeName(iface); if (!inheritedInterfaces.Contains (iname)) userInterfaces.Add (iface);