Proper logging.

nerzhulart · nerzhulart · commit 1ed52e6a0ef1 · 2017-01-10T19:11:52.000+01:00
diff --git a/Mono.Debugging.Win32/CorObjectAdaptor.cs b/Mono.Debugging.Win32/CorObjectAdaptor.cs
@@ -153,7 +153,7 @@ public override string GetTypeName (EvaluationContext ctx, object gtype)
 				return type.GetTypeInfo (cctx.Session).FullName;
 			}
 			catch (Exception ex) {
-				ctx.WriteDebuggerError (ex);
+				DebuggerLoggingService.LogError ("Exception in GetTypeName()", ex);
 				return t.FullName;
 			}
 		}
@@ -1702,7 +1702,7 @@ protected override TypeDisplayData OnGetTypeDisplayData (EvaluationContext ctx,
 					}
 				}
 			} catch (Exception ex) {
-				ctx.WriteDebuggerError (ex);
+				DebuggerLoggingService.LogError ("Exception in OnGetTypeDisplayData()", ex);
 			}
 			if (hasTypeData)
 				return new TypeDisplayData (proxyType, valueDisplayString, typeDisplayString, nameDisplayString, isCompilerGenerated, memberData);

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ public override string GetTypeName (EvaluationContext ctx, object gtype)`
`153`	`153`	`return type.GetTypeInfo (cctx.Session).FullName;`
`154`	`154`	`}`
`155`	`155`	`catch (Exception ex) {`
`156`		`- ctx.WriteDebuggerError (ex);`
	`156`	`+ DebuggerLoggingService.LogError ("Exception in GetTypeName()", ex);`
`157`	`157`	`return t.FullName;`
`158`	`158`	`}`
`159`	`159`	`}`
`@@ -1702,7 +1702,7 @@ protected override TypeDisplayData OnGetTypeDisplayData (EvaluationContext ctx,`
`1702`	`1702`	`}`
`1703`	`1703`	`}`
`1704`	`1704`	`} catch (Exception ex) {`
`1705`		`- ctx.WriteDebuggerError (ex);`
	`1705`	`+ DebuggerLoggingService.LogError ("Exception in OnGetTypeDisplayData()", ex);`
`1706`	`1706`	`}`
`1707`	`1707`	`if (hasTypeData)`
`1708`	`1708`	`return new TypeDisplayData (proxyType, valueDisplayString, typeDisplayString, nameDisplayString, isCompilerGenerated, memberData);`