Handling exceptions in AttachToProcess() and Finish() before ForceExit, because otherwise the session is ended and the exception may be ignored.

Author: nerzhulart

Mono.Debugging/Mono.Debugging.Client/DebuggerSession.cs

@@ -365,8 +365,10 @@ public void AttachToProcess (ProcessInfo proc, DebuggerSessionOptions options)
 						OnAttachToProcess (proc.Id);
 						attached = true;
 					} catch (Exception ex) {
+						// should handle exception before raising Exit event because HandleException may ignore exceptions in Exited state
+						var exceptionHandled = HandleException (ex);
 						ForceExit ();
-						if (!HandleException (ex))
+						if (!exceptionHandled)
 							throw;
 					}
 				});
@@ -511,8 +513,10 @@ public void Finish ()
 					try {
 						OnFinish ();
 					} catch (Exception ex) {
+						// should handle exception before raising Exit event because HandleException may ignore exceptions in Exited state
+						var exceptionHandled = HandleException (ex);
 						ForceExit ();
-						if (!HandleException (ex))
+						if (!exceptionHandled)
 							throw;
 					}
 				});