Merge pull request #104 from mono/Therzok-patch-1

Remove some extra string allocations on getting a display type name d…

Author: David Karlaš

Mono.Debugger.Soft/Mono.Debugger.Soft/MethodMirror.cs

@@ -59,7 +59,7 @@ public string FullName {
 				sb.Append (ReturnType.Name);
 				sb.Append (' ');
 				if (type_namespace != String.Empty)
-					sb.Append (type_namespace + ".");
+					sb.Append (type_namespace).Append (".");
 				sb.Append(type_name);
 				sb.Append(":");
 				sb.Append(Name);

Mono.Debugging/Mono.Debugging.Evaluation/ObjectValueAdaptor.cs

@@ -193,7 +193,7 @@ string GetDisplayTypeName (string typeName, int startIndex, int endIndex)
 					next = genericEndIndex;
 
 				// Append the next generic type component
-				builder.Append (typeName.Substring (i, next - i));
+				builder.Append (typeName, i, next - i);
 
 				i = next + 1;
 			}
@@ -1266,7 +1266,7 @@ public string EvaluateDisplayString (EvaluationContext ctx, object obj, string e
 			int last = 0;
 
 			while (i != -1 && i < expr.Length) {
-				display.Append (expr.Substring (last, i - last));
+				display.Append (expr, last, i - last);
 				i++;
 
 				int j = expr.IndexOf ('}', i);
@@ -1308,7 +1308,7 @@ public string EvaluateDisplayString (EvaluationContext ctx, object obj, string e
 					if (str == null)
 						display.Append ("null");
 					else if (noquotes && IsQuoted (str))
-						display.Append (str.Substring (1, str.Length - 2));
+						display.Append (str, 1, str.Length - 2);
 					else
 						display.Append (str);
 				} else {