part of Bug 48677 - [Expression Evaluator] "Show Value" isn't clickable

Author: David Karlaš

Mono.Debugging/Mono.Debugging.Client/ObjectValue.cs

@@ -154,7 +154,10 @@ public static ObjectValue CreateError (IObjectValueSource source, ObjectPath pat
 
 		public static ObjectValue CreateImplicitNotSupported (IObjectValueSource source, ObjectPath path, string typeName, ObjectValueFlags flags)
 		{
-			return CreateNotSupported (source, path, typeName, "Implicit evaluation is disabled", flags);
+			var val = Create (source, path, typeName);
+			val.flags = flags | ObjectValueFlags.ImplicitNotSupported;
+			val.value = "Implicit evaluation is disabled";
+			return val;
 		}
 
 		public static ObjectValue CreateNotSupported (IObjectValueSource source, ObjectPath path, string typeName, string message, ObjectValueFlags flags)
@@ -681,19 +684,23 @@ public bool IsPrimitive {
 		public bool IsUnknown {
 			get { return HasFlag (ObjectValueFlags.Unknown); }
 		}
-		
+
 		public bool IsNotSupported {
 			get { return HasFlag (ObjectValueFlags.NotSupported); }
 		}
+
+		public bool IsImplicitNotSupported {
+			get { return HasFlag (ObjectValueFlags.ImplicitNotSupported); }
+		}
 
 		public bool IsError {
 			get { return HasFlag (ObjectValueFlags.Error); }
 		}
-		
+
 		public bool IsEvaluating {
 			get { return HasFlag (ObjectValueFlags.Evaluating); }
 		}
-		
+
 		public bool IsEvaluatingGroup {
 			get { return HasFlag (ObjectValueFlags.EvaluatingGroup); }
 		}

Mono.Debugging/Mono.Debugging.Client/ObjectValueFlags.cs

@@ -39,6 +39,7 @@ public enum ObjectValueFlags: uint {
 		Error = 1 << 4,         // The expression evaluation returned an error
 		NotSupported = 1 << 5,  // The expression is valid but its evaluation is not supported
 		Evaluating = 1 << 6,    // The expression is being evaluated. The value will be updated when done.
+		ImplicitNotSupported = 1 << 7,    // The expression is valid but it can't be performed implicitly.
 		KindMask = 0x000000ff,
 
 		Field = 1 << 8,