Merge pull request #98 from mono/helpLink

Added string HelpLink property to ExceptionInfo class

Author: David Karlaš

Mono.Debugging/Mono.Debugging.Client/ExceptionInfo.cs

@@ -108,6 +108,21 @@ public string Message {
 			}
 		}
 
+		ObjectValue helpLinkObject;
+		public string HelpLink {
+			get {
+				if (helpLinkObject == null) {
+					helpLinkObject = exception.GetChild ("HelpLink");
+					if (helpLinkObject != null && helpLinkObject.IsEvaluating) {
+						helpLinkObject.ValueChanged += delegate {
+							NotifyChanged ();
+						};
+					}
+				}
+				return helpLinkObject != null ? helpLinkObject.Value : null;
+			}
+		}
+
 		public ObjectValue Instance {
 			get {
 				if (instance == null)
@@ -151,6 +166,10 @@ public ExceptionStackFrame[] StackTrace {
 					stackTrace = Debugging.Evaluation.ExceptionInfoSource.GetStackTrace (stackTrace.Value);
 				}
 
+				if (!stackTrace.IsArray) {
+					return frames = new ExceptionStackFrame [0];
+				}
+
 				var list = new List<ExceptionStackFrame> ();
 				for (int i = 0; i < stackTrace.ArrayCount; i++)
 					list.Add (new ExceptionStackFrame (stackTrace.GetArrayItem (i, EvaluationOptions.DefaultOptions)));

Mono.Debugging/Mono.Debugging.Evaluation/ExceptionInfoSource.cs

@@ -60,6 +60,7 @@ public ObjectValue CreateObjectValue (bool withTimeout, EvaluationOptions option
 			excInstance.Name = "Instance";
 
 			ObjectValue messageValue = null;
+			ObjectValue helpLinkValue = null;
 			var exceptionType = ctx.Adapter.GetValueType (ctx, Exception.Value);
 
 			// Get the message
@@ -87,6 +88,31 @@ public ObjectValue CreateObjectValue (bool withTimeout, EvaluationOptions option
 
 			messageValue.Name = "Message";
 
+			// Get the help link
+
+			if (withTimeout) {
+				helpLinkValue = ctx.Adapter.CreateObjectValueAsync ("HelpLink", ObjectValueFlags.None, delegate {
+					var mref = ctx.Adapter.GetMember (ctx, Exception, exceptionType, Exception.Value, "HelpLink");
+					if (mref != null) {
+						string val = (string)mref.ObjectValue;
+						return ObjectValue.CreatePrimitive (null, new ObjectPath ("HelpLink"), "string", new EvaluationResult (val), ObjectValueFlags.Literal);
+					}
+
+					return ObjectValue.CreateUnknown ("HelpLink");
+				});
+			} else {
+				var mref = ctx.Adapter.GetMember (ctx, Exception, exceptionType, Exception.Value, "HelpLink");
+				if (mref != null) {
+					string val = (string)mref.ObjectValue;
+					helpLinkValue = ObjectValue.CreatePrimitive (null, new ObjectPath ("HelpLink"), "string", new EvaluationResult (val), ObjectValueFlags.Literal);
+				}
+			}
+
+			if (helpLinkValue == null)
+				helpLinkValue = ObjectValue.CreateUnknown ("HelpLink");
+
+			helpLinkValue.Name = "HelpLink";
+
 			// Inner exception
 
 			ObjectValue childExceptionValue = null;
@@ -160,7 +186,7 @@ public ObjectValue CreateObjectValue (bool withTimeout, EvaluationOptions option
 				stackTraceValue = GetStackTrace (stackTrace.ObjectValue as string);
 			}
 
-			var children = new ObjectValue [] { excInstance, messageValue, stackTraceValue, childExceptionValue, childExceptionsValue };
+			var children = new ObjectValue [] { excInstance, messageValue, helpLinkValue, stackTraceValue, childExceptionValue, childExceptionsValue };
 
 			return ObjectValue.CreateObject (null, new ObjectPath ("InnerException"), type, "", ObjectValueFlags.None, children);
 		}