Skip to content
This repository was archived by the owner on Oct 4, 2021. It is now read-only.

Commit 25e3bbd

Browse files
iantoalmsmonojenkins
authored andcommitted
Re-enable Folder Publishing Support for .Net Core Console and Library projects
Fixes: https://devdiv.visualstudio.com/DevDiv/_queries/edit/1011069 Testing: Create .Net Core Projects - including Http Trigger Function - and verify folder publishing
1 parent 0ada790 commit 25e3bbd

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

main/src/addins/MonoDevelop.AspNetCore/MonoDevelop.AspNetCore.Commands/PublishToFolderBaseCommandHandler.cs

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,19 @@ ProgressMonitor CreateProgressMonitor ()
163163

164164
protected static bool ProjectSupportsFolderPublishing (DotNetProject project)
165165
{
166-
return project != null && project.GetProjectCapabilities ().Any (i => i == "Web" || i == "AzureFunctions" || (project.TargetFramework.Id.IsNetStandardOrNetCoreApp () && i == "FolderPublish"));
166+
// All .Net Core and .Net Standard library projects support folder publishing at this time. We
167+
// previously determined this support by checking for the project capabilities as follows:
168+
//
169+
// - 'Web' Project Capability : Specified only for Asp .Net Core web templates - not Asp.Net
170+
// - 'AzureFunctions' Project Capability : Specified only for C# Azure Function templates
171+
// - 'FolderPublish' Project Capability : Specified in SDK previously for all .Net Core Project
172+
// templates, but it was removed and added to design time targets which we do not use in
173+
// VS4Mac project system
174+
//
175+
// The previous approach fully intersected with all .Net Core and Standard projects and hence
176+
// we can simplify our filter logic, but we should ensure we have a better deterministic plan
177+
// to determine this support going forward
178+
return project != null && project.TargetFramework.Id.IsNetStandardOrNetCoreApp ();
167179
}
168180
}
169181
}

0 commit comments

Comments
 (0)