Merge pull request #8950 from mono/doc-control-dispose

slluis · web-flow · commit 452f8be6ae47 · 2019-10-16T21:30:15.000+02:00
[Ide] Fix document tabs container disposing widgets on mode change
diff --git a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Shell/GtkShellDocumentViewContainerTabs.cs b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Shell/GtkShellDocumentViewContainerTabs.cs
@@ -102,14 +102,6 @@ sealed class GtkShellDocumentTab : Tab
 			public GtkShellDocumentTab (Tabstrip parent, string label) : base (parent, label)
 			{
 			}
-
-			protected override void OnDispose ()
-			{
-				if (Tag is IShellDocumentViewItem disposable)
-					disposable.Dispose ();
-
-				base.OnDispose ();
-			}
 		}
 
 		internal static void UpdateTab (Tab tab, string label, Xwt.Drawing.Image icon, string accessibilityDescription)

Original file line number	Diff line number	Diff line change
`@@ -102,14 +102,6 @@ sealed class GtkShellDocumentTab : Tab`
`102`	`102`	`public GtkShellDocumentTab (Tabstrip parent, string label) : base (parent, label)`
`103`	`103`	`{`
`104`	`104`	`}`
`105`		`-`
`106`		`- protected override void OnDispose ()`
`107`		`- {`
`108`		`- if (Tag is IShellDocumentViewItem disposable)`
`109`		`- disposable.Dispose ();`
`110`		`-`
`111`		`- base.OnDispose ();`
`112`		`- }`
`113`	`105`	`}`
`114`	`106`
`115`	`107`	`internal static void UpdateTab (Tab tab, string label, Xwt.Drawing.Image icon, string accessibilityDescription)`