[Core] Use long in StringTable for better codegen (#8633)

Therzok · web-flow · commit 5324cd2b69c8 · 2019-10-23T20:32:28.000+03:00
Part of VSTS #977400 - Review usages of Interlocked
diff --git a/main/src/core/MonoDevelop.Core/MonoDevelop.Core/StringTable.cs b/main/src/core/MonoDevelop.Core/MonoDevelop.Core/StringTable.cs
@@ -64,7 +64,7 @@ private struct Entry
         private int _localRandom = Environment.TickCount;
 
         // same as above but for users that go directly with unbuffered shared cache.
-        private static int s_sharedRandom = Environment.TickCount;
+        private static long s_sharedRandom = Environment.TickCount;
 
         public StringTable()
         {
@@ -657,7 +657,7 @@ private int LocalNextRandom()
 
         private static int SharedNextRandom()
         {
-            return Interlocked.Increment(ref StringTable.s_sharedRandom);
+            return (int)Interlocked.Increment(ref StringTable.s_sharedRandom);
         }
 
         internal static bool TextEquals(string array, string text, int start, int length)

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ private struct Entry`
`64`	`64`	`private int _localRandom = Environment.TickCount;`
`65`	`65`
`66`	`66`	`// same as above but for users that go directly with unbuffered shared cache.`
`67`		`- private static int s_sharedRandom = Environment.TickCount;`
	`67`	`+ private static long s_sharedRandom = Environment.TickCount;`
`68`	`68`
`69`	`69`	`public StringTable()`
`70`	`70`	`{`
`@@ -657,7 +657,7 @@ private int LocalNextRandom()`
`657`	`657`
`658`	`658`	`private static int SharedNextRandom()`
`659`	`659`	`{`
`660`		`- return Interlocked.Increment(ref StringTable.s_sharedRandom);`
	`660`	`+ return (int)Interlocked.Increment(ref StringTable.s_sharedRandom);`
`661`	`661`	`}`
`662`	`662`
`663`	`663`	`internal static bool TextEquals(string array, string text, int start, int length)`