Merge pull request #9516 from mono/revert-credential-provider

Revert "[PackageManagement] Register credential providers coming from…

Author: sgmunn

main/src/addins/MonoDevelop.PackageManagement/MonoDevelop.PackageManagement/PackageManagementCredentialService.cs

@@ -32,7 +32,6 @@
 using NuGet.CommandLine;
 using NuGet.Credentials;
 using NuGet.Protocol;
-using NuGet.Protocol.Plugins;
 
 namespace MonoDevelop.PackageManagement
 {
@@ -61,7 +60,6 @@ IEnumerable<ICredentialProvider> GetCredentialProviders ()
 			var credentialProviders = new List<ICredentialProvider>();
 
 			credentialProviders.Add (CreateSettingsCredentialProvider ());
-			credentialProviders.AddRange (GetPluginsCredentialProviders ());
 			credentialProviders.Add (new MonoDevelopCredentialProvider ());
 
 			return credentialProviders;
@@ -74,17 +72,6 @@ static SettingsCredentialProvider CreateSettingsCredentialProvider ()
 			return new SettingsCredentialProvider (packageSourceProvider);
 		}
 
-		static IEnumerable<ICredentialProvider> GetPluginsCredentialProviders ()
-		{
-			var builder = new SecurePluginCredentialProviderBuilder (
-				PluginManager.Instance,
-				canShowDialog: false,
-				logger: NuGet.Common.NullLogger.Instance
-			);
-			var providers = builder.BuildAllAsync ().Result;
-			return providers;
-		}
-
 		/// <summary>
 		/// The credential service puts itself in a retry mode if a credential provider
 		/// is checked. This results in credentials stored in the key chain being ignored

main/src/addins/MonoDevelop.PackageManagement/NuGet.Credentials/CredentialService.cs

@@ -103,18 +103,13 @@ public async Task<ICredentials> GetCredentialsAsync (
 
 					CredentialResponse response;
 					if (!TryFromCredentialCache (uri, type, isRetry, provider, out response)) {
-						/* Temporarily disable interactive-ness with secure plugin provider
-						 * to avoid them blocking on requesting user-input for device flow auth
-						 */
-						var nonInteractive = _nonInteractive || provider is SecurePluginCredentialProvider;
-
 						response = await provider.GetAsync (
 							uri,
 							proxy,
 							type,
 							message,
 							isRetry,
-							nonInteractive,
+							_nonInteractive,
 							cancellationToken);
 
 						// Check that the provider gave us a valid response.