[Ide] Properly dispose WizardDialog on completion

sevoku · sevoku · commit fd4f6e149ffa · 2020-01-20T19:45:41.000+01:00
diff --git a/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Wizard/WizardDialogController.cs b/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Wizard/WizardDialogController.cs
@@ -125,14 +125,16 @@ public async Task GoBack (CancellationToken token)
 
 		public bool RunWizard ()
 		{
-			var dialog = new WizardDialog (this);
-			return dialog.Run (Xwt.MessageDialog.RootWindow);
+			using (var dialog = new WizardDialog (this)) {
+				return dialog.Run (Xwt.MessageDialog.RootWindow);
+			}
 		}
 
 		public bool RunWizard (Xwt.WindowFrame parentWindow)
 		{
-			var dialog = new WizardDialog (this);
-			return dialog.Run (parentWindow);
+			using (var dialog = new WizardDialog (this)) {
+				return dialog.Run (parentWindow);
+			}
 		}
 
 		public event EventHandler Completed;

Original file line number	Diff line number	Diff line change
`@@ -125,14 +125,16 @@ public async Task GoBack (CancellationToken token)`
`125`	`125`
`126`	`126`	`public bool RunWizard ()`
`127`	`127`	`{`
`128`		`- var dialog = new WizardDialog (this);`
`129`		`- return dialog.Run (Xwt.MessageDialog.RootWindow);`
	`128`	`+ using (var dialog = new WizardDialog (this)) {`
	`129`	`+ return dialog.Run (Xwt.MessageDialog.RootWindow);`
	`130`	`+ }`
`130`	`131`	`}`
`131`	`132`
`132`	`133`	`public bool RunWizard (Xwt.WindowFrame parentWindow)`
`133`	`134`	`{`
`134`		`- var dialog = new WizardDialog (this);`
`135`		`- return dialog.Run (parentWindow);`
	`135`	`+ using (var dialog = new WizardDialog (this)) {`
	`136`	`+ return dialog.Run (parentWindow);`
	`137`	`+ }`
`136`	`138`	`}`
`137`	`139`
`138`	`140`	`public event EventHandler Completed;`