Skip to content

Commit 20664f1

Browse files
committed
Remove ignored tests and fix CI configuration
- Remove --include-ignored flag from CI test step - Remove test_update_delete_syntax (can't work with in-memory tables) - Unignore all integration tests (postgres, update, delete, sqllogictest) - Unignore test_at_time_zone_function
1 parent c430703 commit 20664f1

File tree

4 files changed

+1
-39
lines changed

4 files changed

+1
-39
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,4 +88,4 @@ jobs:
8888
- uses: Swatinem/rust-cache@v2
8989

9090
- name: Run all tests
91-
run: cargo test --all-features -- --include-ignored
91+
run: cargo test --all-features

tests/integration_test.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ mod integration {
126126

127127
#[tokio::test(flavor = "multi_thread")]
128128
#[serial]
129-
#[ignore] // Slow integration test - run with: cargo test --test integration_test -- --ignored
130129
async fn test_postgres_integration() -> Result<()> {
131130
let server = TestServer::start().await?;
132131
let client = server.client().await?;
@@ -198,7 +197,6 @@ mod integration {
198197

199198
#[tokio::test(flavor = "multi_thread")]
200199
#[serial]
201-
#[ignore] // Slow integration test - run with: cargo test --test integration_test -- --ignored
202200
async fn test_update_operations() -> Result<()> {
203201
let server = TestServer::start().await?;
204202
let client = server.client().await?;
@@ -278,7 +276,6 @@ mod integration {
278276

279277
#[tokio::test(flavor = "multi_thread")]
280278
#[serial]
281-
#[ignore] // Slow integration test - run with: cargo test --test integration_test -- --ignored
282279
async fn test_delete_operations() -> Result<()> {
283280
let server = TestServer::start().await?;
284281
let client = server.client().await?;

tests/sqllogictest.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,6 @@ mod sqllogictest_tests {
218218

219219
#[tokio::test(flavor = "multi_thread")]
220220
#[serial]
221-
#[ignore] // Slow integration test - run with: cargo test --test sqllogictest -- --ignored
222221
async fn run_sqllogictest() -> Result<()> {
223222
let (shutdown_signal, port) = start_test_server().await?;
224223

tests/test_custom_functions.rs

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,7 @@ mod test_custom_functions {
4343
Ok(())
4444
}
4545

46-
// TODO: There's a DataFusion optimizer issue with timestamp timezone handling
47-
// that causes schema mismatches. This needs to be investigated further.
4846
#[tokio::test]
49-
#[ignore]
5047
async fn test_at_time_zone_function() -> Result<()> {
5148
// Create a new SessionContext
5249
let mut ctx = SessionContext::new();
@@ -81,35 +78,4 @@ mod test_custom_functions {
8178
Ok(())
8279
}
8380

84-
#[tokio::test]
85-
#[ignore = "UPDATE/DELETE only work on Delta tables, not in-memory tables"]
86-
async fn test_update_delete_syntax() -> Result<()> {
87-
let ctx = SessionContext::new();
88-
89-
// Create a simple test table
90-
ctx.sql("CREATE TABLE test_table (id INT, name VARCHAR, status VARCHAR)").await?;
91-
ctx.sql("INSERT INTO test_table VALUES (1, 'test1', 'active'), (2, 'test2', 'inactive')").await?;
92-
93-
// Test UPDATE
94-
let update_result = ctx.sql("UPDATE test_table SET status = 'updated' WHERE id = 1").await?;
95-
let _ = update_result.collect().await?; // Execute the update
96-
97-
let df = ctx.sql("SELECT status FROM test_table WHERE id = 1").await?;
98-
let results = df.collect().await?;
99-
assert!(!results.is_empty(), "Expected results from SELECT after UPDATE");
100-
assert_eq!(results[0].num_rows(), 1);
101-
assert_eq!(results[0].column(0).as_string::<i32>().value(0), "updated");
102-
103-
// Test DELETE
104-
let delete_result = ctx.sql("DELETE FROM test_table WHERE id = 2").await?;
105-
let _ = delete_result.collect().await?; // Execute the delete
106-
107-
let df = ctx.sql("SELECT COUNT(*) as cnt FROM test_table").await?;
108-
let results = df.collect().await?;
109-
assert!(!results.is_empty(), "Expected results from COUNT after DELETE");
110-
assert_eq!(results[0].num_rows(), 1);
111-
assert_eq!(results[0].column(0).as_primitive::<datafusion::arrow::datatypes::Int64Type>().value(0), 1);
112-
113-
Ok(())
114-
}
11581
}

0 commit comments

Comments
 (0)