Merge pull request #1 from franzbecker/support-symbol-npm-test-publish

Add symbol support and rename package

Author: franzbecker

package.json

@@ -1,12 +1,12 @@
 {
-  "name": "@khanacademy/flow-to-ts",
-  "version": "0.5.2",
+  "name": "@monzo/flow-to-ts",
+  "version": "0.5.3",
   "publishConfig": {
     "access": "public"
   },
   "repository": {
     "type": "git",
-    "url": "https://github.com/khan/flow-to-ts"
+    "url": "https://github.com/monzo/flow-to-ts"
   },
   "main": "dist/convert.js",
   "bin": {

src/transform.ts

@@ -277,6 +277,11 @@ export const transform = {
       path.replaceWith(t.tsArrayType(elementType));
     },
   },
+  SymbolTypeAnnotation: {
+    exit(path) {
+      path.replaceWith(t.tsSymbolKeyword());
+    },
+  },
   TupleTypeAnnotation: {
     exit(path) {
       const { types } = path.node;

src/transforms/object-type.ts

@@ -138,8 +138,8 @@ export const ObjectTypeCallProperty = {
 
 export const ObjectTypeProperty = {
   exit(path, state) {
+    let { key } = path.node;
     const {
-      key,
       value,
       optional,
       variance,
@@ -151,9 +151,8 @@ export const ObjectTypeProperty = {
     } = path.node; // TODO: static, kind
     const typeAnnotation = t.tsTypeAnnotation(value);
     const initializer = undefined; // TODO: figure out when this used
-    const computed = false; // TODO: maybe set this to true for indexers
+    let computed = false;
     const readonly = variance && variance.kind === "plus";
-
     if (variance && variance.kind === "minus") {
       // TODO: include file and location of infraction
       console.warn("typescript doesn't support writeonly properties");
@@ -162,6 +161,16 @@ export const ObjectTypeProperty = {
       console.warn("we don't handle get() or set() yet, :P");
     }
 
+    if (t.isIdentifier(key)) {
+      if (key.name.startsWith("@@")) {
+        key = t.memberExpression(
+          t.identifier("Symbol"),
+          t.identifier(key.name.replace("@@", ""))
+        );
+        computed = true;
+      }
+    }
+
     if (method) {
       // TODO: assert value is a FunctionTypeAnnotation
       const methodSignature = {

test/fixtures/convert/basic-types/symbol01/flow.js

@@ -0,0 +1 @@
+let a: symbol;

test/fixtures/convert/basic-types/symbol01/ts.js

@@ -0,0 +1 @@
+let a: symbol;

test/fixtures/convert/interfaces/interface-well-known-symbol01/flow.js

@@ -0,0 +1,3 @@
+interface Iterable<T> {
+  @@iterator(): Iterator<T>;
+}

test/fixtures/convert/interfaces/interface-well-known-symbol01/ts.js

@@ -0,0 +1,3 @@
+interface Iterable<T> {
+  [Symbol.iterator](): Iterator<T>;
+}

test/fixtures/convert/intersection-union/union02/flow.js

@@ -0,0 +1 @@
+let obj: string | symbol;

test/fixtures/convert/intersection-union/union02/ts.js

@@ -0,0 +1 @@
+let obj: string | symbol;