Make codechecker happy again

Author: abias

CHANGES.md

@@ -6,6 +6,7 @@ Changes
 
 ### Unreleased
 
+* 2025-10-15 - Make codechecker happy again
 * 2025-10-15 - Tests: Switch Github actions workflows to reusable workflows by Moodle an Hochschulen e.V.
 
 ### v5.0-r1

classes/privacy/provider.php

@@ -32,7 +32,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class provider implements \core_privacy\local\metadata\null_provider {
-
     /**
      * Get the language string identifier with the component's language
      * file to explain why this plugin stores no data.

cli/check_opcache.php

@@ -25,20 +25,23 @@
 
 define('CLI_SCRIPT', true);
 
-require(__DIR__.'/../../../../config.php');
-require_once($CFG->libdir.'/clilib.php');
+require(__DIR__ . '/../../../../config.php');
+require_once($CFG->libdir . '/clilib.php');
 require_once($CFG->libdir . '/filelib.php');
 
 
 // Get cli options.
-list($options, $unrecognized) = cli_get_params(['help' => false,
+[$options, $unrecognized] = cli_get_params(
+    ['help' => false,
                                                     'url' => null,
                                                     'warning' => 80,
                                                     'critical' => 90, ],
-                                               ['h' => 'help',
+    ['h' => 'help',
                                                     'u' => 'url',
                                                     'w' => 'warning',
-                                                    'c' => 'critical', ]);
+    'c' => 'critical',
+    ]
+);
 if ($unrecognized) {
     $unrecognized = implode("\n  ", $unrecognized);
     cli_error(get_string('cliunknowoption', 'admin', $unrecognized));
@@ -60,7 +63,7 @@
 -h, --help      Print out this help
 
 Example:
-\$ sudo -u www-data /usr/bin/php admin/tool/cli/check_opcache.php ".
+\$ sudo -u www-data /usr/bin/php admin/tool/cli/check_opcache.php " .
         "--url=\"https://example.com/admin/tool/opcache/cli/check_opcache_web.php\" --warning=75 --critical=85
 ";
     cli_writeln($help);
@@ -117,16 +120,17 @@
 }
 
 // Concatenate return string including performance data.
-$out = $usedpct."% cache used | ".
-        "used_pct=".$usedpct."%;".$options['warning'].";".$options['critical']." hit_pct=".$hitspct."%; miss_pct=".$misspct."%;";
+$out = $usedpct . "% cache used | " .
+        "used_pct=" . $usedpct . "%;" . $options['warning'] . ";" . $options['critical'] . " hit_pct=" . $hitspct .
+                "%; miss_pct=" . $misspct . "%;";
 
 // Echo return string.
 if ($returnstatus == 0) {
-    cli_writeln('OK - '.$out);
+    cli_writeln('OK - ' . $out);
 } else if ($returnstatus == 1) {
-    cli_writeln('WARNING - '.$out);
+    cli_writeln('WARNING - ' . $out);
 } else {
-    cli_writeln('CRITICAL - '.$out);
+    cli_writeln('CRITICAL - ' . $out);
 }
 
 // Exit with calculated return status.

cli/reset_opcache.php

@@ -24,20 +24,23 @@
 
 define('CLI_SCRIPT', true);
 
-require(__DIR__.'/../../../../config.php');
-require_once($CFG->libdir.'/clilib.php');
+require(__DIR__ . '/../../../../config.php');
+require_once($CFG->libdir . '/clilib.php');
 require_once($CFG->libdir . '/filelib.php');
 
 global $CFG;
 
 
 // Get cli options.
-list($options, $unrecognized) = cli_get_params(['help' => false,
+[$options, $unrecognized] = cli_get_params(
+    ['help' => false,
                                                     'url' => null,
                                                     'reset' => false, ],
-                                               ['h' => 'help',
+    ['h' => 'help',
                                                     'u' => 'url',
-                                                    'r' => 'reset', ]);
+    'r' => 'reset',
+    ]
+);
 if ($unrecognized) {
     $unrecognized = implode("\n  ", $unrecognized);
     cli_error(get_string('cliunknowoption', 'admin', $unrecognized));

index.php

@@ -23,7 +23,7 @@
  */
 
 require(__DIR__ . '/../../../config.php');
-require_once($CFG->libdir.'/adminlib.php');
+require_once($CFG->libdir . '/adminlib.php');
 
 // Set up the plugin's main page as external admin page.
 admin_externalpage_setup('tool_opcache');
@@ -39,7 +39,7 @@
 } else {
     // Page setup.
     $title = get_string('pluginname', 'tool_opcache');
-    $PAGE->set_url('/'.$CFG->admin.'/tool/opcache/index.php');
+    $PAGE->set_url('/' . $CFG->admin . '/tool/opcache/index.php');
     $PAGE->set_title($title);
     $PAGE->set_heading($title);
 

settings.php

@@ -26,7 +26,11 @@
 
 if ($hassiteconfig) {
     // Add the plugin's main page to the server settings category.
-    $settingspage = new admin_externalpage('tool_opcache', new \core\lang_string('pluginname', 'tool_opcache'),
-                                           new \core\url('/'.$CFG->admin.'/tool/opcache/index.php'), 'moodle/site:config');
+    $settingspage = new admin_externalpage(
+        'tool_opcache',
+        new \core\lang_string('pluginname', 'tool_opcache'),
+        new \core\url('/' . $CFG->admin . '/tool/opcache/index.php'),
+        'moodle/site:config'
+    );
     $ADMIN->add('server', $settingspage);
 }