MDLSITE-8102: Plugins and Jira icon in navigation #1393
Conversation
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the top navigation by introducing a new Plugins link, reordering existing entries, and enhancing the Tracker link with an icon and new-window behavior.
- Adds a “Plugins” menu item linking to moodle.org/plugins
- Moves “Downloads” and “Demo” to follow Plugins
- Moves “Tracker” to the end, wraps it in a special class, adds a Jira icon via CSS, and opens it in a new tab
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/theme/Navbar/index.module.css | Defines .nav_tracker .nav_link span rules to display the Jira icon |
| src/theme/Navbar/index.js | Inserts “Plugins”, shifts “Downloads” and “Demo”, and updates “Tracker” with target="_blank" and a wrapper class |
Comments suppressed due to low confidence (1)
src/theme/Navbar/index.js:75
- The new Plugins link and reordered menu items introduce updated navigation behavior. Please add or update unit/integration tests to cover these changes.
<a className={styles.nav_link} href="https://moodle.org/plugins"><span>Plugins</span></a>
|
Hi @durenadev, I think you should now be able to self-merge this. Once you've marked this PR as ready (not draft) you should have an optino to Merge it when ready, because I've now approved it. |
|
Thanks @andrewnicols, The pull request is now marked as ready so that you can proceed with the merge at your convenience. |
2 participants
Hi,
Please note that this commit was made with "--no-verify" due to pre-existing linting errors in the file index.module.css.
According to the Moodle community sites issue:
I applied the necessary changes to the navigation links to:
To coordinate the deployment of these changes with the other environments that share the same header, I would like a code review (validation), but not an approval to proceed to deploy until we can do it within the time window when we will also update the rest.
We are currently discussing different deployment windows and will notify you once we have reviewed the code in this pull request.
Thank you.