Require trailing commas in multi-line Arrays

Fixes #25

Author: andrewnicols

moodle-extra/ruleset.xml

@@ -48,9 +48,6 @@
     <!-- Detect duplicate array keys -->
     <rule ref="Universal.Arrays.DuplicateArrayKey"/>
 
-    <!-- Require a comma after the last element in a multi-line array, but prevent in a single-line array definition -->
-    <rule ref="NormalizedArrays.Arrays.CommaAfterLast"/>
-
     <!-- Disallow use of list() instead of [] -->
     <rule ref="Universal.Lists.DisallowLongListSyntax"/>
 

moodle/ruleset.xml

@@ -13,6 +13,16 @@
         <type>warning</type>
     </rule>
 
+    <!--
+        Trailing commas in multi-line Arrays.
+
+        Agreed in MDLSITE-5873 on 21 May 2020.
+        Affects all major branches since Moodle 3.9.
+
+        Require a comma after the last element in a multi-line array, but prevent in a single-line array definition
+    -->
+    <rule ref="NormalizedArrays.Arrays.CommaAfterLast"/>
+
     <rule ref="Generic.Classes.DuplicateClassName"/>
     <rule ref="Generic.Classes.OpeningBraceSameLine"/>
 
@@ -90,6 +100,8 @@
 
     <rule ref="Zend.Files.ClosingTag"/>
 
+
+
     <!-- Disable this exact error unless it's approved -->
     <rule ref="moodle.Commenting.InlineComment.SpacingAfter">
         <severity>0</severity>