[auto-generated] Update plugin files

Check out the commits that caused these changes: moodlehq/moodleapp@6a0823d...6c5984e

Author: github-actions[bot]

tests/behat/behat_app.php

@@ -283,7 +283,7 @@ public function login(string $username) {
 
         // Wait until the main page appears.
         $this->spin(
-                function($context, $args) {
+                function($context) {
                     $initialpage = $context->getSession()->getPage()->find('xpath', '//page-core-mainmenu') ??
                         $context->getSession()->getPage()->find('xpath', '//page-core-login-change-password') ??
                         $context->getSession()->getPage()->find('xpath', '//page-core-user-complete-profile');
@@ -780,7 +780,7 @@ public function the_app_should_have_opened_a_browser_tab(bool $not = false, ?str
             if (!is_null($urlpattern)) {
                 $this->getSession()->switchToWindow($windowNames[1]);
                 $windowurl = $this->getSession()->getCurrentUrl();
-                $windowhaspattern = !!preg_match("/$urlpattern/", $windowurl);
+                $windowhaspattern = (bool)preg_match("/$urlpattern/", $windowurl);
                 $this->getSession()->switchToWindow($windowNames[0]);
 
                 if ($not === $windowhaspattern) {
@@ -885,6 +885,8 @@ public function i_switch_network_connection(string $mode) {
             case 'offline':
                 $this->runtime_js("network.setForceConnectionMode('none');");
                 break;
+            default:
+                break;
         }
     }
 

tests/behat/behat_app_helper.php

@@ -412,12 +412,9 @@ protected function replace_arguments(string $text): string {
         preg_match_all("/\\$\\{([^:}]+):([^}]+)\\}/", $text, $matches);
 
         foreach ($matches[0] as $index => $match) {
-            switch ($matches[2][$index]) {
-                case 'cmid':
-                    $coursemodule = $DB->get_record('course_modules', ['idnumber' => $matches[1][$index]]);
-                    $text = str_replace($match, $coursemodule->id, $text);
-
-                    break;
+            if ($matches[2][$index] == 'cmid') {
+                $coursemodule = $DB->get_record('course_modules', ['idnumber' => $matches[1][$index]]);
+                $text = str_replace($match, $coursemodule->id, $text);
             }
         }
 
@@ -550,7 +547,7 @@ protected function handle_url(string $customurl, string $successXPath = '') {
         if (!empty($successXPath)) {
             // Wait until the page appears.
             $this->spin(
-                function($context, $args) use ($successXPath) {
+                function($context) use ($successXPath) {
                     $found = $context->getSession()->getPage()->find('xpath', $successXPath);
                     if ($found) {
                         return true;
@@ -597,7 +594,6 @@ protected function get_cm_by_activity_name_and_course(string $activity, string $
         $cmfrom = $cmtable->get_from_sql();
 
         $acttable = new \core\dml\table($activity, 'a', 'a');
-        $actselect = $acttable->get_field_select();
         $actfrom = $acttable->get_from_sql();
 
         $sql = <<<EOF
@@ -662,7 +658,7 @@ protected function get_first_restricted_version_tag(): ?string {
         // Set up relevant tags for each version.
         $usedtags = array_keys($usedtags);
         foreach ($usedtags as $usedtag) {
-            if (!preg_match('~^lms_(from|upto)([0-9]+(?:\.[0-9]+)*)$~', $usedtag, $matches)) {
+            if (!preg_match('~^lms_(from|upto)(\d+(?:\.\d+)*)$~', $usedtag, $matches)) {
                 // No match, ignore.
                 continue;
             }

tests/behat/behat_performance.php

@@ -78,10 +78,8 @@ public function parse_time(string $text): float {
         $spaceindex = strpos($text, ' ');
         $value = floatval(substr($text, 0, $spaceindex));
 
-        switch (substr($text, $spaceindex + 1)) {
-            case 'seconds':
-                $value *= 1000;
-                break;
+        if (substr($text, $spaceindex + 1) == 'seconds') {
+            $value *= 1000;
         }
 
         return $value;
@@ -108,6 +106,8 @@ public function parse_comparison(string $text): Closure {
                 return function ($a, $b) {
                     return $a === $b;
                 };
+            default:
+                break;
         }
     }
 

tests/behat/classes/performance_measure.php

@@ -247,13 +247,13 @@ private function analyseDuration(): void {
      * Analyse long tasks.
      */
     private function analyseLongTasks(): void {
-        $blocking = 0;
+        $blockingDuration = 0;
 
         foreach ($this->longTasks as $longTask) {
-            $blocking += $longTask['duration'] - 50;
+            $blockingDuration += $longTask['duration'] - 50;
         }
 
-        $this->blocking = $blocking;
+        $this->blocking = $blockingDuration;
     }
 
     /**
@@ -269,43 +269,43 @@ private function analyseDatabaseUsage(): void {
     private function analysePerformanceLogs(): void {
         global $CFG;
 
-        $scripting = 0;
-        $styling = 0;
-        $networking = 0;
+        $scriptingDuration = 0;
+        $stylingDuration = 0;
+        $networkingCount = 0;
         $logs = $this->getPerformanceLogs();
 
         foreach ($logs as $log) {
             // TODO this should filter by end time as well, but it seems like the timestamps are not
             // working as expected.
-            if (($log['timestamp'] < $this->start)) {
+            if ($log['timestamp'] < $this->start) {
                 continue;
             }
 
             $message = json_decode($log['message'])->message;
             $messagename = $message->params->name ?? '';
 
             if (in_array($messagename, ['FunctionCall', 'GCEvent', 'MajorGC', 'MinorGC', 'EvaluateScript'])) {
-                $scripting += $message->params->dur;
+                $scriptingDuration += $message->params->dur;
 
                 continue;
             }
 
             if (in_array($messagename, ['UpdateLayoutTree', 'RecalculateStyles', 'ParseAuthorStyleSheet'])) {
-                $styling += $message->params->dur;
+                $stylingDuration += $message->params->dur;
 
                 continue;
             }
 
             if (in_array($messagename, ['XHRLoad']) && !str_starts_with($message->params->args->data->url, $CFG->behat_ionic_wwwroot)) {
-                $networking++;
+                $networkingCount++;
 
                 continue;
             }
         }
 
-        $this->scripting = round($scripting / 1000);
-        $this->styling = round($styling / 1000);
-        $this->networking = $networking;
+        $this->scripting = round($scriptingDuration / 1000);
+        $this->styling = round($stylingDuration / 1000);
+        $this->networking = $networkingCount;
     }
 
     /**

version.php

@@ -6,7 +6,7 @@
 
 defined('MOODLE_INTERNAL') || die;
 
-$plugin->version = 2022080500;
+$plugin->version = 2022090200;
 $plugin->requires = 2016052300;
 $plugin->maturity = MATURITY_STABLE;
 $plugin->release = '4.1.0-dev';