Skip to content

Commit 86db4fb

Browse files
committed
Fix feedback from PR
1 parent 01108b7 commit 86db4fb

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

.github/workflows/test_buildx_and_publish.yml

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -55,15 +55,15 @@ jobs:
5555
sleep 1 # Wait for the server to start
5656
curl --fail http://127.0.0.1:8003/test.php
5757
58-
# Test the DocumentRoot when it is set to a different directory.
58+
# Test the DocumentRoot when it is has been overridden and contains a public directory.
5959
docker run --name test3 -d -p 8004:80 \
6060
-v $PWD/tests/fixtures/documentroot:/srv/moodle \
6161
-e APACHE_DOCUMENT_ROOT=/srv/moodle \
6262
moodle-php-apache
6363
sleep 1 # Wait for the server to start
6464
curl --fail http://127.0.0.1:8004/notpublic.php
6565
66-
# Test the DocumentRoot is not guessed when it has been overriden.
66+
# Test the DocumentRoot is not guessed when it has been overriden and does not contain a public directory.
6767
docker run --name test4 -d -p 8005:80 \
6868
-v $PWD/tests/fixtures/documentroot/public:/srv/moodle \
6969
-e APACHE_DOCUMENT_ROOT=/srv/moodle \
@@ -80,14 +80,6 @@ jobs:
8080
docker logs test3
8181
docker logs test4
8282
83-
- name: Cleanup docker images
84-
run: |
85-
docker rm -f test0
86-
docker rm -f test1
87-
docker rm -f test2
88-
docker rm -f test3
89-
docker rm -f test4
90-
9183
Publish:
9284
# Completely avoid forks and pull requests to try this job.
9385
if: github.repository_owner == 'moodlehq' && contains(fromJson('["push", "workflow_dispatch", "workflow_call"]'), github.event_name)

0 commit comments

Comments
 (0)