Bump self-tests to 4.1 requirements

Trivial for GHA, just change of images to postgres:12, but...

Travis changed the PostgreSQL package for version 11 and up so, instead of
using the "postgres" user it now uses the "travis" one. And the port is
5433 instead of 5432. We use the existence of the PGVER environmental
variable to decide which defaults to use.

More yet, the connection via "localhost" (local net) now requires login and
password, it used to be trust/peer auth mode (not requiring password). If we want to
keep localhost (+ port) working, then we need to edit the  pg_hba.conf file
to trust/peer the local connections and then restart the database.

So, at the end, we are going to use socket connections (host = '')
that is perfectly ok for Travis (non dockered database). Only if they
haven't been configured another way manually (user, host, port).

Author: stronk7

.github/workflows/test.yml

@@ -32,7 +32,7 @@ jobs:
 
     services:
       postgres:
-        image: postgres:10
+        image: postgres:12
         env:
           POSTGRES_USER: 'postgres'
           POSTGRES_HOST_AUTH_METHOD: 'trust'

.travis.yml

@@ -1,11 +1,14 @@
 language: php
 
 addons:
-  postgresql: "10"
+  postgresql: "12"
+  apt:
+    packages:
+      - postgresql-12
+      - postgresql-client-12
 
 services:
   - mysql
-  - postgresql
   - docker
 
 cache:
@@ -18,6 +21,7 @@ php:
 
 env:
   global:
+    - PGVER=12
     - IGNORE_PATHS=ignore
     - IGNORE_NAMES=ignore_name.php
     - MUSTACHE_IGNORE_NAMES=broken.mustache

src/Installer/Database/PostgresDatabase.php

@@ -22,6 +22,28 @@ class PostgresDatabase extends AbstractDatabase
 
     public function getCreateDatabaseCommand()
     {
+        // Travis changed the PostgreSQL package for version 11 and up so, instead of
+        // using the "postgres" user it now uses the "travis" one. And the port is
+        // 5433 instead of 5432. We use the existence of the PGVER environmental
+        // variable to decide which defaults to use.
+        //
+        // More yet, the connection via "localhost" (local net) now requires login and
+        // password, it used to be trust/peer auth mode (not requiring password). If we want to
+        // keep localhost (+ port) working, then we need to edit the  pg_hba.conf file
+        // to trust/peer the local connections and then restart the database.
+        //
+        // So, at the end, we are going to use socket connections (host = '')
+        // that is perfectly ok for Travis (non dockered database). Only if they
+        // haven't been configured another way manually (user, host, port).
+        if ($this->user === 'postgres' && getenv('PGVER') && is_numeric(getenv('PGVER')) && getenv('PGVER') >= 11) {
+            $this->user = 'travis';
+            if ($this->port === '') { // Only if the port is not set.
+                if ($this->host === 'localhost') {
+                    $this->host = ''; // Use sockets or we'll need to edit pg_hba.conf and restart the server. Only if not set.
+                    $this->port = '5433'; // We also need the port to find the correct socket file.
+                }
+            }
+        }
         $pass     = !empty($this->pass) ? 'env PGPASSWORD='.escapeshellarg($this->pass).' ' : '';
         $user     = escapeshellarg($this->user);
         $host     = escapeshellarg($this->host);