Merge pull request #374 from dpalou/MDL-72048

MDL-72048: Disable lint on mobile app templates

Author: kabalin

src/Command/MustacheCommand.php

@@ -62,6 +62,13 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         $code = 0;
         foreach ($files as $file) {
+            if (str_contains($file, '/templates/mobileapp/')) {
+                // Skip app templates for now because they throw many warnings due to custom directives.
+                // To be improved in the future.
+                $this->outputSkip($output, 'Skipping mobile app template: ' . $file);
+                continue;
+            }
+
             $cmd = [
                 'env',
                 '-u',

tests/Command/MustacheCommandTest.php

@@ -17,11 +17,12 @@
 use MoodlePluginCI\Tests\Fake\Process\DummyExecute;
 use MoodlePluginCI\Tests\MoodleTestCase;
 use Symfony\Component\Console\Application;
+use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Tester\CommandTester;
 
 class MustacheCommandTest extends MoodleTestCase
 {
-    protected function executeCommand($pluginDir = null, $moodleDir = null)
+    protected function executeCommand($pluginDir = null, $moodleDir = null, $command = null)
     {
         if ($pluginDir === null) {
             $pluginDir = $this->pluginDir;
@@ -30,7 +31,10 @@ protected function executeCommand($pluginDir = null, $moodleDir = null)
             $moodleDir = $this->moodleDir;
         }
 
-        $command          = new MustacheCommand();
+        if ($command === null) {
+            $command = new MustacheCommand();
+        }
+
         $command->moodle  = new DummyMoodle($moodleDir);
         $command->execute = new DummyExecute();
 
@@ -48,7 +52,20 @@ protected function executeCommand($pluginDir = null, $moodleDir = null)
 
     public function testExecute()
     {
-        $commandTester = $this->executeCommand();
+        // Assert that the mobile app template is skipped.
+        $command = $this->getMockBuilder(MustacheCommand::class)
+            ->onlyMethods(['outputSkip'])
+            ->getMock();
+
+        $command->expects($this->once())
+            ->method('outputSkip')
+            ->with(
+                $this->isInstanceOf(OutputInterface::class),
+                $this->stringContains('/templates/mobileapp/item.mustache'),
+            )
+            ->willReturn(0);
+
+        $commandTester = $this->executeCommand(null, null, $command);
         $this->assertSame(0, $commandTester->getStatusCode());
     }
 

tests/Fixture/moodle-local_ci/templates/mobileapp/item.mustache

@@ -0,0 +1,43 @@
+{{!
+    This file is part of Moodle - http://moodle.org/
+
+    Moodle is free software: you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation, either version 3 of the License, or
+    (at your option) any later version.
+
+    Moodle is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+}}
+{{!
+    @template mobileapp/item
+
+    Template to render an item in the mobile app.
+
+    Classes required for JS:
+    * none
+
+    Data attributes required for JS:
+    * none
+
+    Context variables required for this template:
+    *
+
+    Example context (json):
+    {}
+}}
+{{=<% %>=}}
+<ion-item class="ion-text-wrap ion-text-center">
+    <ion-label>
+        {{ 'fake_string' | translate }}
+    </ion-label>
+</ion-item>
+
+
+<!-- Call a WS when the template is loaded. -->
+<span core-site-plugins-call-ws-on-load name="my_fake_ws" [preSets]="{getFromCache: 0, saveToCache: 0}"></span>