Bump Psalm 3.18.2 and fix reported issues.

Author: kabalin

Makefile

@@ -57,7 +57,7 @@ build/php-cs-fixer.phar:
 
 # Update download URL from https://github.com/vimeo/psalm/releases
 build/psalm.phar:
-	curl -LSs https://github.com/vimeo/psalm/releases/download/3.0.17/psalm.phar -o build/psalm.phar
+	curl -LSs https://github.com/vimeo/psalm/releases/download/3.18.2/psalm.phar -o build/psalm.phar
 
 build/box.phar:
 	@cd build && curl -LSs https://box-project.github.io/box2/installer.php | php

psalm.xml

@@ -40,13 +40,6 @@
             </errorLevel>
         </UnresolvableInclude>
 
-        <!-- Invalid PHPDoc on Symfony process helper -->
-        <PossiblyInvalidArgument>
-            <errorLevel type="suppress">
-                <file name="src/Process/Execute.php"/>
-            </errorLevel>
-        </PossiblyInvalidArgument>
-
         <!-- These are due to how Command classes work with properties -->
         <PossiblyNullArgument>
             <errorLevel type="suppress">
@@ -89,6 +82,8 @@
             <errorLevel type="suppress">
                 <directory name="src/PluginValidate/Requirements"/>
                 <file name="src/Command/CodeFixerCommand.php"/>
+                <file name="src/Installer/AbstractInstaller.php"/>
+                <file name="src/PluginValidate/Finder/FinderInterface.php"/>
             </errorLevel>
         </MissingReturnType>
 

src/Bridge/Moodle.php

@@ -105,7 +105,7 @@ public function getComponentInstallDirectory($component)
         list($type, $name) = $this->normalizeComponent($component);
 
         // Must use reflection to avoid using static cache.
-        $method = new \ReflectionMethod('core_component', 'fetch_plugintypes');
+        $method = new \ReflectionMethod(\core_component::class, 'fetch_plugintypes');
         $method->setAccessible(true);
         $result = $method->invoke(null);
 

src/Command/AddPluginCommand.php

@@ -71,6 +71,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             throw new \InvalidArgumentException('Cannot use both the project argument and the --clone option');
         }
         if (!empty($project)) {
+            /** @psalm-suppress PossiblyInvalidArgument */
             $cloneUrl = sprintf('https://github.com/%s.git', $project);
         } elseif (!empty($clone)) {
             $cloneUrl = $clone;
@@ -81,7 +82,9 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $filesystem->mkdir($storage);
         $storageDir = realpath($validate->directory($storage));
 
-        $process = new Process(sprintf('git clone --depth 1 --branch %s %s', $branch, $cloneUrl), $storageDir);
+        /** @psalm-suppress PossiblyInvalidArgument */
+        $cloneUrl = sprintf('git clone --depth 1 --branch %s %s', $branch, $cloneUrl);
+        $process  = new Process($cloneUrl, $storageDir);
         $this->execute->mustRun($process);
 
         $dumper = new EnvDumper();

src/Command/CoverallsUploadCommand.php

@@ -44,7 +44,9 @@ protected function execute(InputInterface $input, OutputInterface $output)
     {
         $coverage = realpath($input->getOption('coverage-file'));
         if ($coverage === false) {
-            $output->writeln(sprintf('Did not find coverage file at <info>%s</info>', $input->getOption('coverage-file')));
+            /** @psalm-suppress PossiblyInvalidArgument */
+            $message = sprintf('Did not find coverage file at <info>%s</info>', $input->getOption('coverage-file'));
+            $output->writeln($message);
 
             return 0;
         }

src/Parser/StatementFilter.php

@@ -160,7 +160,7 @@ public function arrayStringKeys(Array_ $array)
     {
         $keys = [];
         foreach ($array->items as $item) {
-            if ($item->key instanceof String_) {
+            if (isset($item->key) && $item->key instanceof String_) {
                 $keys[] = $item->key->value;
             }
         }

src/PluginValidate/Finder/TableFinder.php

@@ -39,7 +39,7 @@ protected function findTables($file)
         $tables = [];
         $xml    = simplexml_load_file($file);
         foreach ($xml->xpath('TABLES/TABLE') as $element) {
-            if (null !== $element['NAME']) {
+            if (isset($element['NAME'])) {
                 $tables[] = (string) $element['NAME'];
             }
         }