Skip to content

Commit 58d647a

Browse files
committed
Force php-compatibility dev to be used
Since moodle-cs 3.3.0 we are using "phpcompatibility/php-compatibility": "dev-develop#2fb82334" because the last version released (3.9.5) is from 2019 and missing lots of stuff and, also, compatibility with php81 and up. To be able to install those new moodle-cs versions, all products installing it must explicitly require that php-compatibility version. Once the make a new release, we'll be able to revert this.
1 parent d82d082 commit 58d647a

File tree

4 files changed

+128
-36
lines changed

4 files changed

+128
-36
lines changed

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,8 @@
8181
"nikic/php-parser": "^4.0",
8282
"stecman/symfony-console-completion": "^0.7.0",
8383
"marcj/topsort": "^1.0",
84-
"padraic/phar-updater": "^1.0"
84+
"padraic/phar-updater": "^1.0",
85+
"phpcompatibility/php-compatibility": "dev-develop#2fb82334"
8586
},
8687
"require-dev": {
8788
"phpunit/phpunit": "^6.5",

composer.lock

Lines changed: 123 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
99
The format of this change log follows the advice given at [Keep a CHANGELOG](http://keepachangelog.com).
1010

1111
## [Unreleased]
12+
### Changed
13+
- Updated to `php-compatibility` dev version. This was needed because the last release is from 2019 and, until a new release is available, it was the only way to get it working with PHP 8.1 and above and some good new Sniffs incorporated.
1214

1315
## [3.4.3] - 2022-12-24
1416
### Changed

tests/Command/CodeCheckerCommandTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public function testExecuteFail()
9494
$output = $commandTester->getDisplay();
9595
$this->assertRegExp('/E\.* 8\.* \/ 8 \(100%\)/', $output); // Progress.
9696
$this->assertRegExp('/\/fixable.php/', $output); // File.
97-
$this->assertRegExp('/ (4|5) ERRORS AND (1|2) WARNINGS? AFFECTING 6 /', $output); // Summary (php70 shows one less)
97+
$this->assertRegExp('/ (5|6) ERRORS AND (1|2) WARNINGS? AFFECTING 6 /', $output); // Summary (php70 shows one less)
9898
$this->assertRegexp('/moodle\.Files\.BoilerplateComment\.Wrong/', $output); // Moodle sniff.
9999
$this->assertRegexp('/print_object\(\) is forbidden/', $output); // Moodle sniff.
100100
$this->assertRegexp('/FunctionUse\.RemovedFunctions\.ldap_sort/', $output); // PHPCompatibility sniff.

0 commit comments

Comments
 (0)