Skip to content

Commit 6da610a

Browse files
committed
Update changelog, docs and dist files to show the new option
1 parent 0eec42a commit 6da610a

File tree

6 files changed

+10
-7
lines changed

6 files changed

+10
-7
lines changed

.travis.dist.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,11 @@ script:
5050
- moodle-plugin-ci phplint
5151
- moodle-plugin-ci phpcpd
5252
- moodle-plugin-ci phpmd
53-
- moodle-plugin-ci phpcs
53+
- moodle-plugin-ci phpcs --max-warnings 0
54+
- moodle-plugin-ci phpdoc --max-warnings 0
5455
- moodle-plugin-ci validate
5556
- moodle-plugin-ci savepoints
5657
- moodle-plugin-ci mustache
5758
- moodle-plugin-ci grunt
58-
- moodle-plugin-ci phpdoc --fail-on-warning
59-
- moodle-plugin-ci phpunit
59+
- moodle-plugin-ci phpunit --fail-on-warning
6060
- moodle-plugin-ci behat

docs/CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@ The format of this change log follows the advice given at [Keep a CHANGELOG](htt
1010

1111
## [Unreleased]
1212
### Added
13-
- Add the `--testdox` option within the `phpunit` command.
13+
- Add the `--testdox` option to the `phpunit` command.
14+
- Add the `--max-warnings` option to the `phpdoc` command, so it behaves the same than the `phpcs` command. Note that this modifies current behaviour (see next point) and plugins with only warnings won't be failing any more.
15+
- ACTION SUGGESTED: In order to keep the previous behaviour, it's recommended to use the new `--max-warnings 0` (or any other number) option to specify the warnings threshold.
1416

1517
### Changed
1618
- Updated project dependencies to current [moodle-cs](https://github.com/moodlehq/moodle-cs), [moodle-local_moodlecheck](https://github.com/moodlehq/moodle-local_moodlecheck) and [moodle-local_ci](https://github.com/moodlehq/moodle-local_ci) versions. Also, to various internal / development tools.

docs/GHAFileExplained.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ jobs:
150150

151151
- name: Moodle PHPDoc Checker
152152
if: ${{ always() }}
153-
run: moodle-plugin-ci phpdoc
153+
run: moodle-plugin-ci phpdoc --max-warnings 0
154154

155155
- name: Validating
156156
if: ${{ always() }}

docs/Help.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ you keep this step. To fail on warnings use `--max-warnings 0`
4545

4646
**moodle-plugin-ci phpdoc**
4747

48-
This step runs Moodle PHPDoc checker on your plugin.
48+
This step runs Moodle PHPDoc checker on your plugin. To fail on warnings use `--max-warnings 0`
4949

5050
**moodle-plugin-ci validate**
5151

docs/TravisFileExplained.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ script:
136136
# To fail on warnings use --max-warnings 0
137137
- moodle-plugin-ci phpcs
138138
# This step runs Moodle PHPDoc checker on your plugin.
139+
# To fail on warnings use --max-warnings 0
139140
- moodle-plugin-ci phpdoc
140141
# This step runs some light validation on the plugin file structure
141142
# and code. Validation can be plugin specific.

gha.dist.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ jobs:
8585

8686
- name: Moodle PHPDoc Checker
8787
if: ${{ always() }}
88-
run: moodle-plugin-ci phpdoc
88+
run: moodle-plugin-ci phpdoc --max-warnings 0
8989

9090
- name: Validating
9191
if: ${{ always() }}

0 commit comments

Comments
 (0)