Skip to content

Commit 8b6761a

Browse files
committed
Rebuild AMD test expectations using the new minify/rollup
In MDL-73915 NodeJS was bumped to 16 LTS and also the minify system was modernized, explicitly removing support for IE. That has caused the resulting built AMD files to be different, so we have to put here the new versions in order to get self tests passing. Note that the 4.0 and up minified versions are different from the previous ones, and, although they are interchangeable, we only can assert one of them here. So we go with the 4.0 and up, explicitly disabling the check for older branches (they are sort of past, no matter they are still supported). Also, we have already added as valid the MOODLE_400_STABLE branch in the GHA workflow, so we won't need to add it in some weeks when the branch is created (on release).
1 parent 69f333d commit 8b6761a

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,7 @@ jobs:
103103
moodle-plugin-ci mustache
104104
moodle-plugin-ci grunt || [ \
105105
"$MOODLE_BRANCH" != 'master' -a \
106-
"$MOODLE_BRANCH" != 'MOODLE_311_STABLE' -a \
107-
"$MOODLE_BRANCH" != 'MOODLE_310_STABLE' -a \
108-
"$MOODLE_BRANCH" != 'MOODLE_39_STABLE' ]
106+
"$MOODLE_BRANCH" != 'MOODLE_400_STABLE' ]
109107
moodle-plugin-ci phpdoc
110108
moodle-plugin-ci phpunit --verbose --coverage-text
111109
moodle-plugin-ci behat --profile default

tests/Fixture/moodle-local_ci/amd/build/keys.min.js

Lines changed: 12 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/Fixture/moodle-local_ci/amd/build/keys.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)