Add support in DummyExecute to report the last executed command

That way we'll be able, in all the test using DummyExecute, to
perform assertions against the commands executed, so we can
cover options logic and so on.

Author: stronk7

tests/Fake/Process/DummyExecute.php

@@ -18,8 +18,9 @@
 class DummyExecute extends Execute
 {
     public string $returnOutput = '';
+    public string $lastCmd      = ''; // We need this for assertions against the command run.
 
-    private function getMockProcess($cmd)
+    private function getMockProcess(string $cmd)
     {
         $process = \Mockery::mock('Symfony\Component\Process\Process');
         $process->shouldReceive(
@@ -43,22 +44,12 @@ private function getMockProcess($cmd)
 
     public function run($cmd, ?string $error = null): Process
     {
-        if ($cmd instanceof Process) {
-            // Get the command line from process.
-            $cmd = $cmd->getCommandLine();
-        }
-
-        return $this->helper->run($this->output, $this->getMockProcess($cmd), $error);
+        return $this->helper->run($this->output, $this->getMockProcess($this->getCommandLine($cmd)), $error);
     }
 
     public function mustRun($cmd, ?string $error = null): Process
     {
-        if ($cmd instanceof Process) {
-            // Get the command line from process.
-            $cmd = $cmd->getCommandLine();
-        }
-
-        return $this->helper->mustRun($this->output, $this->getMockProcess($cmd), $error);
+        return $this->helper->mustRun($this->output, $this->getMockProcess($this->getCommandLine($cmd)), $error);
     }
 
     public function runAll(array $processes): void
@@ -73,15 +64,29 @@ public function mustRunAll(array $processes): void
 
     public function passThrough(array $commandline, ?string $cwd = null, ?float $timeout = null): Process
     {
-        return $this->passThroughProcess($this->getMockProcess($commandline));
+        return $this->getMockProcess($this->getCommandLine($commandline));
     }
 
     public function passThroughProcess(Process $process): Process
     {
-        if ($process instanceof \Mockery\MockInterface) {
-            return $process;
+        return $this->getMockProcess($this->getCommandLine($process));
+    }
+
+    /**
+     * Helper function to get the command line from a Process object or array.
+     *
+     * @param Process|array $cmd the command to run and its arguments listed as different entities
+     *
+     * @return string the command to run in a shell
+     */
+    private function getCommandLine($cmd): string
+    {
+        if (is_array($cmd)) {
+            $this->lastCmd = (new Process($cmd))->getCommandLine();
+        } else {
+            $this->lastCmd = $cmd->getCommandLine();
         }
 
-        return $this->getMockProcess($process->getCommandLine());
+        return $this->lastCmd;
     }
 }

tests/MoodleTestCase.php

@@ -16,13 +16,15 @@ class MoodleTestCase extends FilesystemTestCase
 {
     protected string $moodleDir;
     protected string $pluginDir;
+    protected string $lastCmd = ''; // We need this for assertions against the command run.
 
     protected function setUp(): void
     {
         parent::setUp();
 
         $this->moodleDir = $this->tempDir;
         $this->pluginDir = $this->tempDir . '/local/ci';
+        $this->lastCmd   = '';
 
         $this->fs->mirror(__DIR__ . '/Fixture/moodle', $this->moodleDir);
         $this->fs->mirror(__DIR__ . '/Fixture/moodle-local_ci', $this->pluginDir);