Merge pull request #28 from marinaglancy/gruntmap

Grunt should also check .js.map files

Author: kabalin

docs/CHANGELOG.md

@@ -12,6 +12,9 @@ The format of this change log follows the advice given at [Keep a CHANGELOG](htt
 ### Changed
 - Updated [.travis.dist.yml] to use Postgresql 9.6 (Moodle 3.10 new requirement).
 
+### Fixed
+- `moodle-plugin-ci grunt` now also checks `*.js.map` files.
+
 ## [3.0.0] - 2020-07-23
 ### Changed
 - ACTION REQUIRED: project organization renamed to moodlehq. You must update your `.travis.yml` to use `moodlehq/moodle-plugin-ci`

src/Command/GruntCommand.php

@@ -132,7 +132,7 @@ public function validatePluginFiles(OutputInterface $output)
         $code = 0;
 
         // Look for modified files or files that should be deleted.
-        $files = Finder::create()->files()->in($this->backupDir)->name('*.js')->name('*.css')->getIterator();
+        $files = Finder::create()->files()->in($this->backupDir)->name('*.js')->name('*.js.map')->name('*.css')->getIterator();
         foreach ($files as $file) {
             $compareFile = $this->plugin->directory.'/'.$file->getRelativePathname();
             if (!file_exists($compareFile)) {
@@ -148,7 +148,7 @@ public function validatePluginFiles(OutputInterface $output)
         }
 
         // Look for newly generated files.
-        $files = Finder::create()->files()->in($this->plugin->directory)->name('*.js')->name('*.css')->getIterator();
+        $files = Finder::create()->files()->in($this->plugin->directory)->name('*.js')->name('*.js.map')->name('*.css')->getIterator();
         foreach ($files as $file) {
             if (!file_exists($this->backupDir.'/'.$file->getRelativePathname())) {
                 $output->writeln(sprintf('<error>File is newly generated and needs to be added: %s</error>', $file->getRelativePathname()));

tests/Command/GruntCommandTest.php

@@ -193,5 +193,25 @@ public function testValidatePluginFiles()
         $output = new BufferedOutput();
         $this->assertSame(1, $command->validatePluginFiles($output));
         $this->assertSame("File is newly generated and needs to be added: amd/build/new.min.js\n", $output->fetch());
+
+        $command->restorePlugin();
+        $this->assertSame(0, $command->validatePluginFiles($emptyOutput));
+        $this->assertSame('', $emptyOutput->fetch());
+
+        $this->fs->remove($this->pluginDir.'/amd/build/keys.min.js.map');
+
+        $output = new BufferedOutput();
+        $this->assertSame(1, $command->validatePluginFiles($output));
+        $this->assertSame("File no longer generated and likely should be deleted: amd/build/keys.min.js.map\n", $output->fetch());
+
+        $command->restorePlugin();
+        $this->assertSame(0, $command->validatePluginFiles($emptyOutput));
+        $this->assertSame('', $emptyOutput->fetch());
+
+        $this->fs->touch($this->pluginDir.'/amd/build/new.min.js.map');
+
+        $output = new BufferedOutput();
+        $this->assertSame(1, $command->validatePluginFiles($output));
+        $this->assertSame("File is newly generated and needs to be added: amd/build/new.min.js.map\n", $output->fetch());
     }
 }