MOBILE-1576 quiz: Don't show download if max attempts or no questions

Author: dpalou

www/addons/mod_quiz/services/prefetch_handler.js

@@ -69,16 +69,7 @@ angular.module('mm.addons.mod_quiz')
      * @return {Number}         Promise resolved with revision.
      */
     self.getRevision = function(module, courseId) {
-        var promise;
-        if (module.instance) {
-            promise = $q.when(module.instance);
-        } else {
-            promise = $mmaModQuiz.getQuiz(courseId, module.id).then(function(quiz) {
-                return quiz.id;
-            });
-        }
-
-        return promise.then(function(quizId) {
+        return $mmaModQuiz.getQuizIdFromModule(module, courseId).then(function(quizId) {
             return $mmaModQuiz.getUserAttempts(quizId).then(function(attempts) {
                 return $mmaModQuiz.getQuizRevisionFromAttempts(attempts);
             });
@@ -96,16 +87,7 @@ angular.module('mm.addons.mod_quiz')
      * @return {Promise}         Promise resolved with timemodified.
      */
     self.getTimemodified = function(module, courseId) {
-        var promise;
-        if (module.instance) {
-            promise = $q.when(module.instance);
-        } else {
-            promise = $mmaModQuiz.getQuiz(courseId, module.id).then(function(quiz) {
-                return quiz.id;
-            });
-        }
-
-        return promise.then(function(quizId) {
+        return $mmaModQuiz.getQuizIdFromModule(module, courseId).then(function(quizId) {
             return $mmaModQuiz.getUserAttempts(quizId).then(function(attempts) {
                 return $mmaModQuiz.getQuizTimemodifiedFromAttempts(attempts);
             });
@@ -124,7 +106,15 @@ angular.module('mm.addons.mod_quiz')
      */
     self.isDownloadable = function(module, courseId) {
         return $mmaModQuiz.getQuiz(courseId, module.id).then(function(quiz) {
-            return quiz.allowofflineattempts === 1;
+            if (quiz.allowofflineattempts !== 1 || quiz.hasquestions === 0) {
+                return false;
+            }
+
+            // Not downloadable if we reached max attempts.
+            return $mmaModQuiz.getUserAttempts(quiz.id).then(function(attempts) {
+                var isLastFinished = !attempts.length || $mmaModQuiz.isAttemptFinished(attempts[attempts.length - 1].state);
+                return quiz.attempts === 0 || quiz.attempts > attempts.length || !isLastFinished;
+            });
         });
     };
 

www/addons/mod_quiz/services/quiz.js

@@ -870,6 +870,27 @@ angular.module('mm.addons.mod_quiz')
         });
     };
 
+    /**
+     * Get a quiz id given a course module object.
+     *
+     * @module mm.addons.mod_quiz
+     * @ngdoc method
+     * @name $mmaModQuiz#getQuizIdFromModule
+     * @param {Object} module   Course module.
+     * @param {Number} courseId Course ID.
+     * @param {String} [siteId] Site ID. If not defined, current site.
+     * @return {Promise}        Promise resolved when the Quiz is retrieved.
+     */
+    self.getQuizIdFromModule = function(module, courseId, siteId) {
+        if (module.instance) {
+            return $q.when(module.instance);
+        } else {
+            return self.getQuiz(courseId, module.id, siteId).then(function(quiz) {
+                return quiz.id;
+            });
+        }
+    };
+
     /**
      * Get a readable Quiz grade method.
      *