Skip to content

Commit 3297ec0

Browse files
committed
MOBILE-3413 h5p: Fix h5p iframe not visible in offline
1 parent bea4e50 commit 3297ec0

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/components/iframe/iframe.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -75,17 +75,17 @@ export class CoreIframeComponent implements OnInit, OnChanges {
7575
const navCtrl = this.svComponent ? this.svComponent.getMasterNav() : this.navCtrl;
7676
this.iframeUtils.treatFrame(iframe, false, navCtrl);
7777

78-
if (this.loading) {
79-
iframe.addEventListener('load', () => {
80-
this.loading = false;
81-
this.loaded.emit(iframe); // Notify iframe was loaded.
82-
});
78+
iframe.addEventListener('load', () => {
79+
this.loading = false;
80+
this.loaded.emit(iframe); // Notify iframe was loaded.
81+
});
8382

84-
iframe.addEventListener('error', () => {
85-
this.loading = false;
86-
this.domUtils.showErrorModal('core.errorloadingcontent', true);
87-
});
83+
iframe.addEventListener('error', () => {
84+
this.loading = false;
85+
this.domUtils.showErrorModal('core.errorloadingcontent', true);
86+
});
8887

88+
if (this.loading) {
8989
setTimeout(() => {
9090
this.loading = false;
9191
}, this.IFRAME_TIMEOUT);

src/providers/utils/iframe.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export class CoreIframeUtilsProvider {
5555
checkOnlineFrameInOffline(element: any, isSubframe?: boolean): boolean {
5656
const src = element.src || element.data;
5757

58-
if (src && !this.urlUtils.isLocalFileUrl(src) && !this.appProvider.isOnline()) {
58+
if (src && src != 'about:blank' && !this.urlUtils.isLocalFileUrl(src) && !this.appProvider.isOnline()) {
5959
if (element.classList.contains('core-iframe-offline-disabled')) {
6060
// Iframe already hidden, stop.
6161
return true;

0 commit comments

Comments
 (0)