MOBILE-4638 chore: Adapt icons to match LMS on MDL-82497

crazyserver · crazyserver · commit 361fa4ee989c · 2024-08-19T11:40:11.000+02:00
diff --git a/src/addons/messages/pages/discussion/discussion.ts b/src/addons/messages/pages/discussion/discussion.ts
@@ -96,7 +96,7 @@ export class AddonMessagesDiscussionPage implements OnInit, OnDestroy, AfterView
     groupMessagingEnabled: boolean;
     isGroup = false;
     members: {[id: number]: AddonMessagesConversationMember} = {}; // Members that wrote a message, indexed by ID.
-    favouriteIcon = 'fa-star';
+    favouriteIcon = 'fas-star';
     deleteIcon = 'fas-trash';
     blockIcon = 'fas-user-lock';
     addRemoveIcon = 'fas-user-plus';
diff --git a/src/addons/qtype/calculated/component/addon-qtype-calculated.html b/src/addons/qtype/calculated/component/addon-qtype-calculated.html
@@ -29,7 +29,7 @@
             </ng-container>
         </div>
         <ion-icon *ngIf="question.input.correctIcon" class="core-correct-icon ion-align-self-center" slot="end"
-            [name]="question.input.correctIcon" [color]="[question.input.correctIconColor]" />
+            [name]="question.input.correctIcon" [color]="[question.input.correctIconColor]" [ariaLabel]="question.input.correctIconLabel" />
     </ion-item>
 
     <!-- Display unit options after the answer input. -->
diff --git a/src/addons/qtype/ordering/component/addon-qtype-ordering.html b/src/addons/qtype/ordering/component/addon-qtype-ordering.html
@@ -19,11 +19,11 @@
 
                 @if (dragDisabled) {
                 @if (item.correctClass === 'correct') {
-                <ion-icon name="fas-check" slot="start" />
+                <ion-icon name="fas-check-double" slot="start" [ariaLabel]="'core.question.correct' | translate" color="success" />
                 } @else if (item.correctClass === 'incorrect') {
-                <ion-icon name="fas-xmark" slot="start" />
+                <ion-icon name="fas-xmark" slot="start" [ariaLabel]="'core.question.incorrect' | translate" color="danger" />
                 } @else if (item.correctClass.startsWith('partial')) {
-                <ion-icon name="far-square-check" slot="start" />
+                <ion-icon name="fas-check" slot="start" [ariaLabel]="'core.question.partiallycorrect' | translate" color="warning" />
                 }
                 }
 
diff --git a/src/addons/qtype/ordering/component/ordering.ts b/src/addons/qtype/ordering/component/ordering.ts
@@ -74,7 +74,9 @@ export class AddonQtypeOrderingComponent extends CoreQuestionBaseComponent<Addon
         this.question.items = itemsElements.map(element => {
             // Remove correctness icons from the content.
             const itemContentEl = element.querySelector<HTMLElement>('[data-itemcontent]');
-            itemContentEl?.querySelector('.icon.fa-check, .icon.fa-remove, .icon.fa-check-square')?.remove();
+            itemContentEl?.querySelector(
+                '.icon.fa-check, .icon.fa-remove, .icon.fa-check-square, .icon.fa-check-double, .icon.fa-xmark',
+            )?.remove();
 
             return {
                 id: element.id,
diff --git a/src/addons/qtype/shortanswer/component/addon-qtype-shortanswer.html b/src/addons/qtype/shortanswer/component/addon-qtype-shortanswer.html
@@ -11,6 +11,6 @@
             [attr.name]="question.input.name" [value]="question.input.value" autocorrect="off" [disabled]="question.input.readOnly"
             [label]="'addon.mod_quiz.answercolon' | translate" />
         <ion-icon *ngIf="question.input.correctIcon" class="core-correct-icon" slot="end" [name]="question.input.correctIcon"
-            [color]="[question.input.correctIconColor]" />
+            [color]="[question.input.correctIconColor]" [ariaLabel]="question.input.correctIconLabel" />
     </ion-item>
 </ion-list>
diff --git a/src/core/features/fileuploader/components/audio-recorder/audio-recorder.html b/src/core/features/fileuploader/components/audio-recorder/audio-recorder.html
@@ -43,7 +43,7 @@ <h1>{{ 'core.fileuploader.audiotitle' | translate }}</h1>
             <div class="core-audio-recorder--control">
                 <ion-button shape="round" fill="clear" [ariaLabel]="'core.fileuploader.stoprecording' | translate"
                     (click)="stopRecording()">
-                    <ion-icon slot="icon-only" name="fa-check" />
+                    <ion-icon slot="icon-only" name="fas-check" aria-hidden="true" />
                 </ion-button>
             </div>
         </div>
diff --git a/src/core/features/grades/services/grades-helper.ts b/src/core/features/grades/services/grades-helper.ts
@@ -553,17 +553,26 @@ export class CoreGradesHelperProvider {
             row.itemtype = 'agg_sum';
             row.icon = 'moodle-agg-sum';
             row.iconAlt = Translate.instant('core.grades.aggregatesum');
-        } else if (text.indexOf('/outcomes') > -1 || text.indexOf('fa-tasks') > -1 || text.indexOf('fa-list-check') > -1) {
+        } else if (
+            text.indexOf('/outcomes') > -1 ||
+            text.indexOf('fa-tasks') > -1 ||
+            text.indexOf('fa-list-check') > -1
+        ) {
             row.itemtype = 'outcome';
             row.icon = 'fas-list-check';
             row.iconAlt = Translate.instant('core.grades.outcome');
         } else if (text.indexOf('i/folder') > -1 || text.indexOf('fa-folder') > -1 || text.indexOf('category-content') > -1) {
             row.itemtype = 'category';
             row.icon = 'fas-folder';
             row.iconAlt = Translate.instant('core.grades.category');
-        } else if (text.indexOf('/manual_item') > -1 || text.indexOf('fa-square-o') > -1) {
+        } else if (
+            text.indexOf('/manual_item') > -1 ||
+            text.indexOf('fa-square-o') > -1 ||
+            text.indexOf('fa-pencil-square-o') > -1 ||
+            text.indexOf('fa-pen-to-square') > -1
+        ) {
             row.itemtype = 'manual';
-            row.icon = 'far-square';
+            row.icon = 'fas-pen-to-square';
             row.iconAlt = Translate.instant('core.grades.manualitem');
         } else if (text.indexOf('/calc') > -1 || text.indexOf('fa-calculator') > -1) {
             row.itemtype = 'calc';
diff --git a/src/core/features/mainmenu/services/mainmenu.ts b/src/core/features/mainmenu/services/mainmenu.ts
@@ -113,7 +113,7 @@ export class CoreMainMenuProvider {
             const id = url + '#' + type;
             if (!icon) {
                 // Icon not defined, use default one.
-                icon = type == 'embedded' ? 'fa-expand' : 'fa-link'; // @todo Find a better icon for embedded.
+                icon = type == 'embedded' ? 'fas-expand' : 'fas-link'; // @todo Find a better icon for embedded.
             }
 
             if (!map[id]) {
diff --git a/src/core/features/question/classes/base-question-component.ts b/src/core/features/question/classes/base-question-component.ts
@@ -494,18 +494,22 @@ export class CoreQuestionBaseComponent<T extends AddonModQuizQuestion = AddonMod
             question.input.correctClass = 'core-question-incorrect';
             question.input.correctIcon = 'fas-xmark';
             question.input.correctIconColor = CoreIonicColorNames.DANGER;
+            question.input.correctIconLabel = 'core.question.incorrect';
         } else if (input.classList.contains('correct')) {
             question.input.correctClass = 'core-question-correct';
-            question.input.correctIcon = 'fas-check';
+            question.input.correctIcon = 'fas-check-double';
             question.input.correctIconColor = CoreIonicColorNames.SUCCESS;
+            question.input.correctIconLabel = 'core.question.correct';
         } else if (input.classList.contains('partiallycorrect')) {
             question.input.correctClass = 'core-question-partiallycorrect';
-            question.input.correctIcon = 'fas-square-check';
+            question.input.correctIcon = 'fas-check';
             question.input.correctIconColor = CoreIonicColorNames.WARNING;
+            question.input.correctIconLabel = 'core.question.partiallycorrect';
         } else {
             question.input.correctClass = '';
             question.input.correctIcon = '';
             question.input.correctIconColor = '';
+            question.input.correctIconLabel = '';
         }
 
         if (question.input.isInline) {
@@ -829,6 +833,7 @@ export type AddonModQuizQuestionTextInput = {
     correctClass?: string;
     correctIcon?: string;
     correctIconColor?: string;
+    correctIconLabel?: string;
 };
 
 /**
diff --git a/src/core/features/search/components/global-search-result/global-search-result.ts b/src/core/features/search/components/global-search-result/global-search-result.ts
@@ -61,7 +61,7 @@ export class CoreSearchGlobalSearchResultComponent implements OnChanges {
      */
     private computeRenderedIcon(): string | null {
         return this.result.module?.name === 'forum'  && this.result.module.area === 'post'
-            ? 'fa-message'
+            ? 'fas-message'
             : null;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -19,11 +19,11 @@`
`19`	`19`
`20`	`20`	`@if (dragDisabled) {`
`21`	`21`	`@if (item.correctClass === 'correct') {`
`22`		`- <ion-icon name="fas-check" slot="start" />`
	`22`	`+ <ion-icon name="fas-check-double" slot="start" [ariaLabel]="'core.question.correct' \| translate" color="success" />`
`23`	`23`	`} @else if (item.correctClass === 'incorrect') {`
`24`		`- <ion-icon name="fas-xmark" slot="start" />`
	`24`	`+ <ion-icon name="fas-xmark" slot="start" [ariaLabel]="'core.question.incorrect' \| translate" color="danger" />`
`25`	`25`	`} @else if (item.correctClass.startsWith('partial')) {`
`26`		`- <ion-icon name="far-square-check" slot="start" />`
	`26`	`+ <ion-icon name="fas-check" slot="start" [ariaLabel]="'core.question.partiallycorrect' \| translate" color="warning" />`
`27`	`27`	`}`
`28`	`28`	`}`
`29`	`29`
Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ export class CoreMainMenuProvider {`
`113`	`113`	`const id = url + '#' + type;`
`114`	`114`	`if (!icon) {`
`115`	`115`	`// Icon not defined, use default one.`
`116`		`- icon = type == 'embedded' ? 'fa-expand' : 'fa-link'; // @todo Find a better icon for embedded.`
	`116`	`+ icon = type == 'embedded' ? 'fas-expand' : 'fas-link'; // @todo Find a better icon for embedded.`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`if (!map[id]) {`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ export class CoreSearchGlobalSearchResultComponent implements OnChanges {`
`61`	`61`	`*/`
`62`	`62`	`private computeRenderedIcon(): string \| null {`
`63`	`63`	`return this.result.module?.name === 'forum' && this.result.module.area === 'post'`
`64`		`- ? 'fa-message'`
	`64`	`+ ? 'fas-message'`
`65`	`65`	`: null;`
`66`	`66`	`}`
`67`	`67`