MOBILE-4759 siteplugins: Use Activity components only in the proper site plugin

Author: crazyserver

src/addons/mod/assign/assign.module.ts

@@ -61,7 +61,7 @@ export async function getModAssignServices(): Promise<Type<unknown>[]> {
  *
  * @returns Assign component modules.
  */
-export async function getModAssignComponentModules(): Promise<unknown[]> {
+export async function getModAssignComponentModules(): Promise<Type<unknown>[]> {
     const { AddonModAssignSubmissionPluginComponent } =
         await import('@addons/mod/assign/components/submission-plugin/submission-plugin');
     const { AddonModAssignFeedbackPluginComponent } =

src/addons/mod/data/components/index/index.ts

@@ -56,7 +56,7 @@ import { CorePromiseUtils } from '@singletons/promise-utils';
 import { CoreObject } from '@singletons/object';
 import { CoreAlerts } from '@services/overlays/alerts';
 import { Translate } from '@singletons';
-import { CoreCompileHtmlComponentModule } from '@features/compile/components/compile-html/compile-html.module';
+import { CoreCompileHtmlComponent } from '@features/compile/components/compile-html/compile-html';
 import { CoreCourseComponentsModule } from '@features/course/components/components.module';
 import { CoreSharedModule } from '@/core/shared.module';
 
@@ -73,7 +73,7 @@ const contentToken = '<!-- CORE-DATABASE-CONTENT-GOES-HERE -->';
     imports: [
         CoreSharedModule,
         CoreCourseComponentsModule,
-        CoreCompileHtmlComponentModule,
+        CoreCompileHtmlComponent,
     ],
 })
 export class AddonModDataIndexComponent extends CoreCourseModuleMainActivityComponent implements OnInit, OnDestroy {

src/addons/mod/data/components/search-modal/search-modal.ts

@@ -31,7 +31,7 @@ import { AddonModDataHelper } from '../../services/data-helper';
 import { AddonModDataSearchDataParams } from '../index';
 import { AddonModDataTemplateType } from '../../constants';
 import { CoreSharedModule } from '@/core/shared.module';
-import { CoreCompileHtmlComponentModule } from '@features/compile/components/compile-html/compile-html.module';
+import { CoreCompileHtmlComponent } from '@features/compile/components/compile-html/compile-html';
 
 /**
  * Page that displays the search modal.
@@ -43,7 +43,7 @@ import { CoreCompileHtmlComponentModule } from '@features/compile/components/com
     standalone: true,
     imports: [
         CoreSharedModule,
-        CoreCompileHtmlComponentModule,
+        CoreCompileHtmlComponent,
     ],
 })
 export class AddonModDataSearchModalComponent implements OnInit {

src/addons/mod/data/pages/edit/edit.ts

@@ -47,7 +47,7 @@ import { CoreLoadings } from '@services/overlays/loadings';
 import { CoreWSError } from '@classes/errors/wserror';
 import { CoreArray } from '@singletons/array';
 import { CoreAlerts } from '@services/overlays/alerts';
-import { CoreCompileHtmlComponentModule } from '@features/compile/components/compile-html/compile-html.module';
+import { CoreCompileHtmlComponent } from '@features/compile/components/compile-html/compile-html';
 import { CoreSharedModule } from '@/core/shared.module';
 
 /**
@@ -60,7 +60,7 @@ import { CoreSharedModule } from '@/core/shared.module';
     standalone: true,
     imports: [
         CoreSharedModule,
-        CoreCompileHtmlComponentModule,
+        CoreCompileHtmlComponent,
     ],
 })
 export default class AddonModDataEditPage implements OnInit {

src/addons/mod/data/pages/entry/entry.ts

@@ -47,7 +47,7 @@ import { CoreAlerts } from '@services/overlays/alerts';
 import { Translate } from '@singletons';
 import { CoreCommentsComponentsModule } from '@features/comments/components/components.module';
 import { CoreRatingComponentsModule } from '@features/rating/components/components.module';
-import { CoreCompileHtmlComponentModule } from '@features/compile/components/compile-html/compile-html.module';
+import { CoreCompileHtmlComponent } from '@features/compile/components/compile-html/compile-html';
 import { CoreSharedModule } from '@/core/shared.module';
 
 /**
@@ -60,7 +60,7 @@ import { CoreSharedModule } from '@/core/shared.module';
     standalone: true,
     imports: [
         CoreSharedModule,
-        CoreCompileHtmlComponentModule,
+        CoreCompileHtmlComponent,
         CoreRatingComponentsModule,
         CoreCommentsComponentsModule,
     ],

src/addons/mod/quiz/quiz.module.ts

@@ -57,23 +57,6 @@ export async function getModQuizServices(): Promise<Type<unknown>[]> {
     ];
 }
 
-/**
- * Get quiz component modules.
- *
- * @returns Quiz component modules.
- */
-export async function getModQuizComponentModules(): Promise<unknown[]> {
-    const { AddonModQuizAttemptInfoComponent } = await import('@addons/mod/quiz/components/attempt-info/attempt-info');
-    const { AddonModQuizAttemptStateComponent } = await import('@addons/mod/quiz/components/attempt-state/attempt-state');
-    const { AddonModQuizQuestionCardComponent } = await import('@addons/mod/quiz/components/question-card/question-card');
-
-    return [
-        AddonModQuizAttemptInfoComponent,
-        AddonModQuizAttemptStateComponent,
-        AddonModQuizQuestionCardComponent,
-    ];
-}
-
 const routes: Routes = [
     {
         path: ADDON_MOD_QUIZ_PAGE_NAME,

src/addons/mod/workshop/workshop.module.ts

@@ -58,7 +58,7 @@ export async function getModWorkshopServices(): Promise<Type<unknown>[]> {
  *
  * @returns Workshop component modules.
  */
-export async function getModWorkshopComponentModules(): Promise<unknown[]> {
+export async function getModWorkshopComponentModules(): Promise<Type<unknown>[]> {
     const { AddonModWorkshopAssessmentStrategyComponent } =
         await import('@addons/mod/workshop/components/assessment-strategy/assessment-strategy');
 

src/core/features/compile/components/compile-html/compile-html.module.ts

@@ -47,6 +47,7 @@ import { CorePromiseUtils } from '@singletons/promise-utils';
 import { CoreWS } from '@services/ws';
 import { CoreDom } from '@singletons/dom';
 import { CoreAlerts } from '@services/overlays/alerts';
+import { CoreSharedModule } from '@/core/shared.module';
 
 /**
  * This component has a behaviour similar to $compile for AngularJS. Given an HTML code, it will compile it so all its
@@ -56,7 +57,7 @@ import { CoreAlerts } from '@services/overlays/alerts';
  * component is used, so it can slow down the app.
  *
  * This component has its own module to prevent circular dependencies. If you want to use it,
- * you need to import CoreCompileHtmlComponentModule.
+ * you need to import CoreCompileHtmlComponent.
  *
  * You can provide some Javascript code (as text) to be executed inside the component. The context of the javascript code (this)
  * will be the component instance created to compile the template. This means your javascript code can interact with the template.
@@ -67,6 +68,8 @@ import { CoreAlerts } from '@services/overlays/alerts';
     selector: 'core-compile-html',
     template: '<core-loading [hideUntil]="loaded"><ng-container #dynamicComponent /></core-loading>',
     styles: [':host { display: contents; }'],
+    standalone: true,
+    imports: [CoreSharedModule],
 })
 export class CoreCompileHtmlComponent implements OnChanges, OnDestroy, DoCheck {
 

src/core/features/compile/components/compile-html/compile-html.ts

@@ -122,9 +122,9 @@ import { getCompetencyServices } from '@addons/competency/competency.module';
 import { getCourseCompletionServices } from '@addons/coursecompletion/coursecompletion.module';
 import { getMessageOutputServices } from '@addons/messageoutput/messageoutput.module';
 import { getMessagesServices } from '@addons/messages/messages.module';
-import { getModAssignComponentModules, getModAssignServices } from '@addons/mod/assign/assign.module';
-import { getModQuizComponentModules, getModQuizServices } from '@addons/mod/quiz/quiz.module';
-import { getModWorkshopComponentModules, getModWorkshopServices } from '@addons/mod/workshop/workshop.module';
+import { getModAssignServices } from '@addons/mod/assign/assign.module';
+import { getModQuizServices } from '@addons/mod/quiz/quiz.module';
+import { getModWorkshopServices } from '@addons/mod/workshop/workshop.module';
 import { getNotesServices } from '@addons/notes/notes.module';
 import { getNotificationsServices } from '@addons/notifications/notifications.module';
 import { getPrivateFilesServices } from '@addons/privatefiles/privatefiles.module';
@@ -172,9 +172,6 @@ export class CoreCompileProvider {
     ];
 
     protected readonly LAZY_IMPORTS = [
-        getModAssignComponentModules,
-        getModQuizComponentModules,
-        getModWorkshopComponentModules,
         getCoreStandaloneComponents,
         getCourseStandaloneComponents,
         getSitePluginsDirectives,